chore(release): move dev to 2.39.0 after the v2.38.0 release - #3076
Conversation
dev was left carrying the just-published 2.38.0, which fails tests/release-version-line.test.ts on dev and on every PR against it: the in-tree version must never be behind a released one. bun scripts/bump-dev-version.ts 2.38.0 package.json chose 2.39.0, per the documented rule that a stable release consumes its core and dev moves to the next minor. dev-version-bump.yml did not fire on its own. It resolves the workflow from the default branch on a release event, and the version it would have used was the one this commit writes by hand.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe package version in ChangesPackage release metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the development version to 2.39.0 after the 2.38.0 release, with the version-line check passing; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 74 / 80이 PR은 제품 기능을 바꾸지 않습니다. 지금 왜 지금 필요한가. 태그 버전 숫자는 손으로 고른 게 아닙니다. 본문이 말한 대로 이 PR은 워크플로가 연 것이 아닙니다. 작성자는 lidge-jun이고, 브랜치 이름은 워크플로 파일 그 구멍을 이 PR에서 고치지 않습니다. 이 PR은 한 줄만 올립니다. types.ts/config.ts 분할과 무관합니다. 같은 라인 3 (package.json) - version 2.38.0 → 2.39.0. 이 PR의 유일한 변경. 헬퍼 규칙과 맞다 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Ingwannu
left a comment
There was a problem hiding this comment.
Approved exact head e25e3170a39cf764bd84a9c3d907ce45a07422ac. Stable release v2.38.0, GitHub Release, and origin/main all resolve to ebb4d552e8f463bc1519ab5aab602342b0ba70dc; this PR changes only package.json from 2.38.0 to the helper-selected next integration version 2.39.0. git diff --check is clean and the exact-head Cross-platform CI, service lifecycle, React Doctor, hygiene, and target checks are green. This restores the release-version-line invariant for dev and its dependent pull requests. The currently non-firing automatic bump workflow should be repaired separately; it does not change the correctness of this one-line bump.
Summary
devwas left carrying2.38.0, the version just published to npm.tests/release-version-line.test.tsasserts the in-tree version is never behind a released one, so this fails ondevitself and on every PR opened against it until it is fixed.bun scripts/bump-dev-version.ts 2.38.0 package.jsonchose2.39.0:{"changed":true,"version":"2.39.0","reason":"2.38.0 is a stable release, so dev moves to the next minor 2.39.0"}That follows the documented rule: a published stable consumes its core, so
devmoves to the next minor. A published prerelease would instead have leftdevon that same core.dev-version-bump.ymldid not fire on its own. On areleaseevent GitHub resolves the workflow from the default branch, and it only reachedmainin the v2.37.0 promotion, so the automatic path has not had a release to act on yet. Same manual step as #3045 after v2.37.0.Verification
bun test tests/release-version-line.test.ts— 3 pass / 0 fail.Checklist
devSummary by CodeRabbit