Skip to content

[WRONG BRANCH] chore(release): move preview to 2.39.0-preview.20260831 - #3077

Draft
lidge-jun wants to merge 1 commit into
previewfrom
codex/preview-version-2390
Draft

[WRONG BRANCH] chore(release): move preview to 2.39.0-preview.20260831#3077
lidge-jun wants to merge 1 commit into
previewfrom
codex/preview-version-2390

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

Cross-platform CI went red on preview right after the v2.38.0 promotion, on macos and test 1/4. One assertion, in both:

(fail) release version line > the in-tree version is never behind a released one

Every other check on that run passed.

The cause is ordering, not a defect. The preview promotion was prepared as 2.38.0-preview.20260831 while 2.38.0 was still unpublished, which was correct at the time. Publishing the stable 2.38.0 immediately afterwards consumed that core, and a prerelease of an already-released version is by definition behind it.

Move the preview line to the next unconsumed core, 2.39.0-preview.20260831, matching dev's move to 2.39.0 in #3076.

Verification

bun test tests/release-version-line.test.ts — 3 pass / 0 fail.

Note

enforce-target fails on any PR not targeting dev; that applies here as it does to promotion PRs.

Checklist

Summary by CodeRabbit

  • Chores
    • Updated the package to version 2.39.0-preview.20260831.

The preview promotion carried 2.38.0-preview.20260831, chosen before v2.38.0
was published. Publishing the stable 2.38.0 made that prerelease BEHIND a
released version, and tests/release-version-line.test.ts asserts the in-tree
version is never behind one. Cross-platform CI on preview went red on exactly
that assertion (macos and test 1/4), with every other check green.

A prerelease outranks nothing once its own core ships. Move the preview line to
the next unconsumed core, matching dev's move to 2.39.0.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner August 31, 2026 11:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T11:38:54.718078Z bb61c99 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title chore(release): move preview to 2.39.0-preview.20260831 [WRONG BRANCH] chore(release): move preview to 2.39.0-preview.20260831 Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • wrong target branch (preview); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 31, 2026 11:37
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e9bc38e6-c794-42f5-bb7b-23052c524fc2

📥 Commits

Reviewing files that changed from the base of the PR and between 93704b4 and bb61c99.

📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The package version in package.json changes from 2.38.0-preview.20260831 to 2.39.0-preview.20260831. No exported or public entities change.

Changes

Package Version

Layer / File(s) Summary
Update package version
package.json
Line 3 changes the package version from 2.38.0-preview.20260831 to 2.39.0-preview.20260831.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bb61c

This localized version update moves the preview line to 2.39.0-preview.20260831; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: ingwannu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the preview version to 2.39.0-preview.20260831. The [WRONG BRANCH] prefix adds context but does not make the title unclear or unrelated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/preview-version-2390

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 66 / 80

이 PR은 제품 기능을 바꾸지 않습니다. previewpackage.json 버전 한 줄만 고칩니다. 지금 origin/preview2.38.0-preview.20260831입니다. 이 PR은 그걸 2.39.0-preview.20260831으로 올립니다. 파일은 package.json 하나이고, 더하기 1 빼기 1입니다. 베이스는 preview이고, 초안입니다. 제목의 [WRONG BRANCH]는 enforce-target가 dev가 아닌 PR을 거절할 때 붙는 표시입니다. 승격 PR과 같은 표시입니다. 점수 66.

왜 지금 빨간가. tests/release-version-line.test.ts는 트리 안 번호가 이미 나온 태그보다 뒤에 있으면 실패합니다. 미리보기 번호는 같은 코어의 스테이블보다 뒤입니다. 테스트가 그걸 잠가 두었습니다. v2.34.0-preview.1v2.34.0보다 작습니다. 오늘 v2.38.0이 나가기 전에는 2.38.0-preview.20260831이 맞았습니다. 스테이블이 그 코어를 소비한 뒤에는, 같은 미리보기가 뒤에 서게 됩니다. 본문이 말한 대로 preview의 macos와 test 1/4가 그 한 단언 때문에 빨개진 겁니다.

올리는 숫자는 dev의 #3076과 짝입니다. #3076이 dev2.39.0으로 가면, preview는 그 다음 코어의 미리보기 2.39.0-preview.20260831을 드는 게 맞습니다. 같은 칸을 dev에 넣는 PR이 아닙니다. #3076은 dev의 스테이블 칸이고, 이 PR은 preview의 미리보기 칸입니다. 같이 넣으면 안 됩니다. types.ts/config.ts 분할과 무관합니다. 프리뷰 배포는 계획에 없습니다.

지금 dev HEAD는 그대로 5cec0a33e (#3074)입니다. 이 PR은 dev를 건드리지 않습니다. 작성자는 lidge-jun입니다. 워크플로 dev-version-bump.ymldev만 밀고, preview는 안 만집니다. 그래서 이 미리보기 줄도 사람 손입니다. #3076 리뷰에서 적은 대로, 릴리스 워크플로가 기본 토큰으로 릴리스를 만들어서 범프 워크플로가 한 번도 안 돌았습니다. 그 구멍은 여기도 고치지 않습니다.

초안을 dev로 바꾸지 마세요. preview에 머지해야 그 브랜치의 빨간불이 꺼집니다. enforce-target 빨강은 이 저장소에서 preview 대상 PR의 기본값입니다. 가짜로 dev를 가리키면 미리보기 줄이 안 고쳐집니다.

라인 package.json version - 2.38.0-preview.20260831 → 2.39.0-preview.20260831. 이 PR의 유일한 변경
경로 tests/release-version-line.test.ts 131-132 - 같은 코어의 미리보기는 자기 스테이블보다 뒤. 오늘 v2.38.0이 그 규칙을 실제로 터뜨렸다
경로 Enforce PR target / [WRONG BRANCH] - 베이스가 preview라서 게이트가 빨개다. 승격 PR과 같은 표시다. 베이스를 dev로 바꾸지 마라
경로 .github/workflows/dev-version-bump.yml - preview를 안 민다. 이 줄은 원래 사람 손이다
경로/심볼 #3076 - dev의 2.39.0 짝. 칸이 다르니 이 PR을 그쪽으로 합치거나 닫지 마라

메인테이너의 판단이 필요한 지점

  • 초안을 ready로 올리고 preview에 머지할지. 한 줄이고 preview CI 빨간불을 끈다
  • #3076과 순서를 맞출지. 칸이 달라서 같이 넣지 않아도 된다
  • preview 줄도 나중에 자동으로 밀 장치를 만들지. 지금 워크플로는 dev만 본다

너의 추천
초안을 ready로 올린 뒤 preview에 머지하세요. 베이스를 dev로 바꾸지 마세요. #3076과 칸이 다르니 닫지도 말고 합치지도 마세요. 분할 무효화·중복 닫기 해당 없음. 프리뷰 배포는 계획에 없습니다. 라벨은 바꾸지 않습니다.

이 댓글은 grok-bot이 작성했습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant