chore(repo): remove agent scratch files and guard against them - #6140
Conversation
Drop the repo-local .agents skill, the root design-debt.md audit and the train 4 lane _handoff.md notes. repo-hygiene now treats .agents as agent state and rejects tracked design-debt.md or _handoff.md files.
|
Maintainer dev integration (MAINTAINERS.md dev-only path): repository cleanup requested by the project owner before the 2.69.0 release. Test-only guard plus deletions; hygiene and structure tests pass locally (67/0) and the new guard was driven red. Cross-platform CI runs on the promotion commits. |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d85c12742c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # becomes tracked again. | ||
| .codexclaw/ | ||
| **/.codexclaw/ | ||
| .agents/ |
There was a problem hiding this comment.
Retain the management API isolation recipe
When a contributor or agent needs to exercise the management API, this blanket ban accompanies deletion of .agents/skills/testing-opencodex-management-api/SKILL.md and its only discoverable link, and a repo-wide search finds no equivalent guidance outside historical devlog records. The deleted recipe documents the non-obvious fact that changing OPENCODEX_HOME alone can still alter personal shell and client state, requiring a disposable OS account and redirected HOME; without it, the obvious local test setup can modify a developer's real environment. Relocate the recipe to a tracked contributor-documentation path and link it before forbidding .agents/ rather than discarding it.
Useful? React with 👍 / 👎.
Summary
Removes agent working files that reached the repository before the 2.69.0 release, and guards against them coming back.
.agents/skills/testing-opencodex-management-api/: a repo-local agent skill added during release train 4 (docs: plan client/proxy train and isolate management API testing #6095/Release train 4: clients/proxy lane (JEV notes, memory routing, macOS proxy, Kilo, Factory Droid, test recipe) #6124). The pointer to it inAGENTS.mdis removed with it.design-debt.md: a scoped design audit of one Muse tool-choice change that a bug-train squash (fix: integrate bug train 9B provider, Claude, and Windows repairs #5985) put at the repository root.devlog/_plan/260927_release_train_4/*/_handoff.md: notes the train 4 lanes wrote for each other when they were stopped and resumed. Each lane's numbered docs keep the durable record.tests/ci-workflows/repo-hygiene.test.tsnow treats.agentsas agent state (with a matching.gitignoreentry) and rejects any trackeddesign-debt.mdor_handoff.md.Verification
bun test tests/ci-workflows/repo-hygiene.test.ts tests/ci-workflows/structure-ssot.test.ts: 67 pass, 0 fail.design-debt.mdfailsno agent scratch notes are tracked; removing it again passes.bun run structure:checkandbun run privacy:scan: passed.Checklist