Skip to content

chore(repo): remove agent scratch files and guard against them - #6140

Merged
lidge-jun merged 1 commit into
devfrom
codex/260928-remove-agent-scratch
Sep 27, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260928-remove-agent-scratch

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Removes agent working files that reached the repository before the 2.69.0 release, and guards against them coming back.

tests/ci-workflows/repo-hygiene.test.ts now treats .agents as agent state (with a matching .gitignore entry) and rejects any tracked design-debt.md or _handoff.md.

Verification

  • bun test tests/ci-workflows/repo-hygiene.test.ts tests/ci-workflows/structure-ssot.test.ts: 67 pass, 0 fail.
  • Guard driven red: restoring design-debt.md fails no agent scratch notes are tracked; removing it again passes.
  • bun run structure:check and bun run privacy:scan: passed.
  • Cross-platform CI runs on the release promotion commits that follow this change.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Drop the repo-local .agents skill, the root design-debt.md audit and the train 4 lane _handoff.md notes. repo-hygiene now treats .agents as agent state and rejects tracked design-debt.md or _handoff.md files.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 27, 2026 22:23
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer dev integration (MAINTAINERS.md dev-only path): repository cleanup requested by the project owner before the 2.69.0 release. Test-only guard plus deletions; hygiene and structure tests pass locally (67/0) and the new guard was driven red. Cross-platform CI runs on the promotion commits.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun merged commit b3d445d into dev Sep 27, 2026
6 of 9 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T22:26:49.801529Z d85c127 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun deleted the codex/260928-remove-agent-scratch branch September 27, 2026 22:24
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b5ce2523-0f05-4a65-833e-733d37e1a075

📥 Commits

Reviewing files that changed from the base of the PR and between 081b670 and d85c127.

📒 Files selected for processing (10)
  • .agents/skills/testing-opencodex-management-api/SKILL.md
  • .gitignore
  • AGENTS.md
  • design-debt.md
  • devlog/_plan/260927_release_train_4/account-pool/_handoff.md
  • devlog/_plan/260927_release_train_4/bug-hardening/_handoff.md
  • devlog/_plan/260927_release_train_4/gui-ux/_handoff.md
  • devlog/_plan/260927_release_train_4/issue-triage/_handoff.md
  • devlog/_plan/260927_release_train_4/picker-ca/_handoff.md
  • tests/ci-workflows/repo-hygiene.test.ts
 _____________________________________________________________________________________________________________________
< The average user doesn't give a damn what happens, as long as (1) it works and (2) it's fast. - Daniel J. Bernstein >
 ---------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d85c12742c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitignore
# becomes tracked again.
.codexclaw/
**/.codexclaw/
.agents/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain the management API isolation recipe

When a contributor or agent needs to exercise the management API, this blanket ban accompanies deletion of .agents/skills/testing-opencodex-management-api/SKILL.md and its only discoverable link, and a repo-wide search finds no equivalent guidance outside historical devlog records. The deleted recipe documents the non-obvious fact that changing OPENCODEX_HOME alone can still alter personal shell and client state, requiring a disposable OS account and redirected HOME; without it, the obvious local test setup can modify a developer's real environment. Relocate the recipe to a tracked contributor-documentation path and link it before forbidding .agents/ rather than discarding it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant