Repository navigation
Various improvements - #387
Merged
Merged
Conversation
alex-leb
self-requested a review
April 3, 2026 20:23
Contributor
Author
|
ping @alex-leb thank you! |
n-rodriguez
force-pushed
the
wip/gemspec
branch
from
September 29, 2026 20:15
c86ec58 to
0c2c3e8
Compare
Contributor
|
Thanks for this, @n-rodriguez, and sorry it sat so long. The
The Ruby 4.0 job will still show a 403 from the coverage step. That happens on every PR from a fork (read-only token) and is on our side. Thanks again! |
This reverts commit 144dc21. CI's simplecov-check-action reads files[].covered_percent from coverage/coverage.json, which is the simplecov-json format. simplecov_json_formatter writes meta/coverage/groups instead, so the coverage step would crash with nil.select on master.
Setting AllCops/Exclude replaces RuboCop's defaults (vendor/**/*, tmp/**/*, ...), so CI's rubocop job linted gems under vendor/bundle and crashed on a gem's .rubocop.yml. Merge with the defaults instead.
As gemspec development dependencies these were skipped with BUNDLE_WITHOUT=development; keep that working now they live in the Gemfile. Also require rubocop-performance >= 1.24, the first release that can be loaded under plugins: in .rubocop.yml.
Dir[] would pick up untracked files under lib/ (scratch files, WIP) at release time. Use git ls-files for the same paths so only committed files ship; the file list is unchanged today.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: better reviewed commit by commit
Thank you!