Repository navigation
fix(deps): move zod to 4.6.7 and bundled undici to 6.29.1 for two high advisories - #329
Merged
Merged
Conversation
…h advisories The required `audit` check now fails on every pull request, including #328, because of two advisories published after main's last green run: - GHSA-mrhx-c7xc-m3w5 (zod < 4.6.6, high): validating oversized constrained collections can exhaust memory. - GHSA-xjj6-f33q-929c (undici >= 6.23.0 < 6.29.1, high): an unhandled error on excessive content-encodings is a denial of service. undici reaches this repository through @actions/github and @actions/http-client (^6.23.0), which are bundled into all three Actions. As in #251, this edits only those two bun.lock entries: zod 4.6.5 -> 4.6.7 (inside ^4.6.5, published 2026-10-12) and undici 6.29.0 -> 6.29.1 (inside ^6.23.0, published 2026-10-15). Both clear the 3-day minimumReleaseAge, and both integrity hashes match the npm registry. Re-resolving the lockfile would have moved unrelated packages. `bun install --frozen-lockfile` accepts the edit, and `audit:gate` now reports no advisories at any severity. I regenerated packages/ci/dist under linux/amd64 oven/bun:1.4.2. The diff is zod's and undici's own code. `schema:emit` leaves schema/adr.schema.json byte-identical. typecheck, build, lint, and the full suite (4544 pass, 2 skip) pass, and each bundle run under Node with no event prints the same result as main's. Signed-off-by: Mark Beacom <m@beacom.dev>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Decisions governing this change5 accepted decisions govern this change
Links point at |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The required
auditcheck now fails on every pull request, #328 included. Two high advisories were published aftermain's last green run on 2026-10-11:@actions/githuband@actions/http-client, which are bundled into all three Actions.As in #251, this edits only those two
bun.lockentries, so unrelated packages don't move:^4.6.5, published 2026-10-12.^6.23.0, published 2026-10-15.Both are past the 3-day
minimumReleaseAge, and their integrity hashes match the npm registry.bun install --frozen-lockfileaccepts the edit.audit:gatenow reports no advisories at any severity, so the moderate one it listed before is gone too.Checklist
schema:emitleavesschema/adr.schema.jsonbyte-identical with zod 4.6.7.packages/ci/distunder linux/amd64oven/bun:1.4.2. The diff is zod's and undici's own code, and nothing else moves.audit:gatefailed locally onmain's lockfile with the same two advisories; it passes after.bun run typecheck && bun run build && bun test && bun run lintpass (4544 pass, 2 skip, 0 fail).Notes for reviewers
packages/ci/**, so it needsgate-change-acknowledged.main's:index.jsexits early outside a pull request,queue-action.jsasks for a token, andportal-action.jsrefuses a payload with no visibility.@adrkit/coreand@adrkit/mcpstill declarezod: ^4.6.5. A consumer's fresh install already resolves 4.6.7, but the floor would only exclude 4.6.5 if it moved to^4.6.6in the next lockstep release. The audit gate's stated scope doesn't cover consumer installs, so I left that out of this fix.