Repository navigation
Restore RNA annotation defaults and parent grouping in Rust-backed analysis - #139
Closed
Jaureguy760 wants to merge 2 commits into
Closed
Jaureguy760 wants to merge 2 commits into
Jaureguy760 wants to merge 2 commits into
Conversation
This was referenced Oct 16, 2026
Jaureguy760
added a commit
that referenced
this pull request
Oct 16, 2026
Integrate single-cell and RNA compatibility fixes, checked count arithmetic, correct workflow inputs and coverage boundaries, and align documentation and source-build requirements. Validate with all seven PR workflows, including Python 3.10–3.13, native Rust tests, wheels, Galaxy/Nextflow regressions and amd64/arm64 containers. Public chromosome 21 wide-reference comparisons and clean source installation also pass. Supersedes #138 and #139; no release is published.
Collaborator
Author
|
Superseded by #140, now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk RNA annotation defaults had changed from exon-first to gene-first, and the original parent-grouping flags were rejected before reaching Rust. Restore exon → transcript → gene selection and route all four parent aliases through the existing Rust grouping parameter before deduplication and fitting.
Parse exact GTF/GFF3 attribute keys, including a final attribute without a trailing semicolon. Automatic selection requires a key present on every retained row, preserving archived fallback to a complete alternate key. Reject missing or empty feature/parent identifiers with record coordinates before writing BED output. Reject contradictory per-variant/parent-grouping requests, retain archived missing-parent-column warning behavior, and update existing help and documentation.
Validation:
Counting and bulk inference remain Rust-only. No Rust algorithms, dispersion policies, likelihoods, pseudocount rules or variant policies change. Inputs are synthetic; this does not certify real RNA or single-cell biological performance.
Based directly on dev; independent of single-cell PR #138. No generated data or investigation reports are included.
Tested remote head: 920b42a; source tree: 85160008495629137789fff043841b92c2c6975d. Local and remote trees match. All seven final-head workflows passed: CI (Python 3.10–3.13, Rust tests, Clippy and formatting), Build (Linux/macOS wheels), Documentation, CodeQL, Security, Ecosystem (Galaxy/Nextflow), and Container CI (native amd64/arm64). Linux Python 3.11: 548 passed, 76 skipped, 1 deselected. The broader RNA audit was rerun on the final source: 144/144 counting comparisons, 32/32 analysis comparisons, all four parent aliases and the full VCF/GTF counting command passed.