Repository navigation
Restore analysis parity and correct integrated workflow behavior - #140
Merged
Merged
Conversation
Combine single-cell and RNA annotation fixes with checked count arithmetic, workflow input corrections, native process regressions, documentation cleanup, and consistent source-build and release validation requirements.
Jaureguy760
marked this pull request as ready for review
October 16, 2026 22:07
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-cell mixed phased/unphased genotypes could select phased inference and crash, ATAC workflow preprocessing discarded peak membership, and fragment coverage was passed into allelic inference without observed alleles. This PR combines #138 and #139 with the remaining integration fixes and repository cleanup.
Changes:
Validation:
Limits: real-data validation covers one chromosome and donor genotype on provider-aligned BAMs, with technical cell partitions. It does not certify biological calibration, a new remapping pass, complete BAM-based single-cell Nextflow inference, or a full release matrix. All seven final-head PR workflows passed: core CI (Python 3.10–3.13, Rust, Clippy and lint), Documentation, CodeQL, Security, Linux/macOS wheel Build, Ecosystem (Galaxy, four pipeline compatibility checks and six native process/boundary regressions), and native amd64/arm64 Container CI. Linux/Python 3.11 reports 822 passed, 76 skipped, one deselected. No release is tagged or published.
Supersedes #138 and #139; close those PRs after this replacement merges. Investigation inputs, scripts and reports remain outside Git. Final reviewed head: 061e7e7; source tree: 8e67178bfc1ad4dbc2a162d834fecbccf3f49bda. Runtime source matches locally tested commit efee99a; the follow-up adds only CI dependencies needed by the now-active single-cell H5AD stub. Local and remote final trees match.