Repository navigation
chore(MultiSelector): format the source with the repository's Prettier settings - #9247
Conversation
…r settings #9148 left the trigger's mergeRefs(...) call unformatted; lint-staged then rewrites it in any local merge of main, and those pull requests fail changeset coverage. Formatting only, with a [chore] patch Changeset.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
This looks ready to merge. The MultiSelector change is exactly what Prettier produces from the current file with the repository's settings, and the patch [chore] Changeset is the one the coverage check requires for package source. A small correction to the description: Prettier also adds a trailing comma after ref, so the edit is not only whitespace, though the call is unchanged. Another 19 non-test files under packages/core/src still fail prettier --check, so the same reformat on merge can come back when main next touches one of them; that is worth a separate cleanup and does not block this change.
[Automated review]
Maintainer impact
packages/core/src/MultiSelector/MultiSelector.tsxlanded on main without Prettier formatting (themergeRefs(...)call in the trigger props, from #9148). Main's lint doesn't format-check files a pull request leaves alone, but the pre-commit formatter rewrites the file in any local merge of main that stages it. Pull requests that merge main locally therefore pick up a reformat of shipped source they never meant to change, and then fail "Check Changeset coverage". Two open pull requests already fail that way.Intended invariant
Shipped source on main is Prettier-clean, so merging main never rewrites a file the pull request didn't change.
Change
prettier --writeonMultiSelector.tsx: the onemergeRefs(...)call is re-wrapped, and no tokens change. A patch Changeset in the "Other Changes" category covers the shipped file, as the coverage check requires for package source.Evidence
prettier --checkon main'sMultiSelector.tsxreports code style issues; two open pull requests' lint fails "Check Changeset coverage" on exactly this reformat.prettier --checkpasses; the diff is whitespace and line breaks only.Scope
Testing
pnpm exec prettier --check packages/core/src/MultiSelector/MultiSelector.tsxpnpm check:changesetsPosted by Cindy's agent on her behalf.