Repository navigation
spec(ContextMenu): touch-opened menus lift with a tint, grow from the finger, and use named springs - #9423
Merged
Conversation
… finger, and use named springs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
Contributor
Author
|
/approve-spec 41af8fb |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
People who hold a finger on a ContextMenu trigger on a phone get a menu that feels native: the trigger lifts above a page tinted with the theme's overlay color (no blur), the menu grows out of the finger and shrinks back into it, and the motion plays on three named springs. People who open a menu with a mouse or keyboard see no change. The look and motion are unbuilt, so the records mark them as implementation gaps. No prop, export or theme token changes.
Decision
The owner's two lines, 2026-11-01:
Proposal A covers all three open points: lift A (tint only, no blur), glass A (the menu grows as its own surface, with no glass blob), and springs A (three ContextMenu spring roles).
Changed records
component:ContextMenuspec:AST-017FR60 open-layer allowance.spec:AST-094springs.contextMenuLift(0.8, 0.32 s),springs.contextMenuDismiss(0.85, 0.35 s) andsprings.contextMenuMorph(0.8, 0.3 s), owned bycomponent:ContextMenu(DEC-5) and played only in a touch-opened ContextMenu.springs.contextMenuMorph.spec:AST-108is unchanged. Its FR3 already covers every role inspec:AST-094FR4, so the new rows follow tempo and character with no edit there.Unblocks
Writing rubric results
R1 narration: none; every added sentence states behavior, an owner or an implementation gap in the present tense.
R2 research: none in the record; the iOS comparison and the options stay in the decision brief outside the repo.
R3 evidence: the spring sources cite measurements, not changes. The DEC-2 element counts measured on unmerged code were left out, and the verification rows name evidence gaps instead.
R4 rejected alternatives: one, DEC-2 (a copy of the trigger), one line.
R5 change references: none in the records.
R6 open questions: none.
Checks:
pnpm install --frozen-lockfile,pnpm check:knowledge("Knowledge templates and records are aligned."), and prettier on both records.