Repository navigation
Security hotfix: remediate authentication, code execution, and SSRF findings - #16
Merged
Yuqing (mydmdm) merged 4 commits intoOct 5, 2026
Conversation
Require bearer authentication for ServeCore, disable client-supplied Python execution and dynamic backend registration, and document the breaking security hotfix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reference the immutable upstream commit because pull requests cannot publish tags to the upstream repository. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enforce per-session capabilities, remove client bytecode deserialization, and eliminate untrusted backend request paths while documenting legacy checkout instructions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the post-merge checkout command without depending on the pull request author's fork. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Release prerequisite: publish the legacy tag in the upstream repository before advertising the README clone command: git tag -a legacy-unsafe-pre-security-hotfix 2e1825ee2bc38cb783bab9d8ec3e5ae99a93ba46 \
-m "Known-vulnerable snapshot before security hardening; isolated historical reproduction only"
git push origin legacy-unsafe-pre-security-hotfixThe tag currently present in the PR source fork does not make an upstream clone command work; it must be created by a maintainer with push access to |
Collaborator
Author
|
The upstream annotated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARROT_API_KEYbearer token for every ServeCore HTTP request and validate it again when sessions are created/v1/py_native_callreturns410 GoneReported finding coverage
marshalserialization utilities and the server-sideFunctionTypeconstruction/data flow were removed; the endpoint returns410 Gone.requests.postsinks were removed.PARROT_API_KEY, all endpoints enforce bearer authentication, and session creation validates the key.Breaking changes
Python native calls and dynamic backend registration are intentionally unavailable. The vulnerable baseline is upstream commit
2e1825ee2bc38cb783bab9d8ec3e5ae99a93ba46. The annotated upstream taglegacy-unsafe-pre-security-hotfixhas been published at that commit. The README labels it unsupported/known-vulnerable and gives a clone command usinghttps://github.com/microsoft/ParrotServe.gitfor isolated security environments.Validation
python3 -m pytest -q tests/serve/test_http_security.py(6 passed)python3 -m py_compile ...for all changed Python modules and testsgit diff --checkmarshal.loads/marshal.dumps, function-code serialization helpers, request-controlledEngineConfig(**payload), or FastChat workerrequests.postsink