Repository navigation
[release-branch.go1.27] Respect OpenSSL ML-DSA external-mu capabilities - #2663
Merged
George Adams (gdams) merged 4 commits intoOct 28, 2026
Merged
George Adams (gdams) merged 4 commits into
George Adams (gdams) merged 4 commits into
Conversation
Use a per-parameter provider capability check before native external-mu signing and retain the existing Go fallback for unsupported providers. Update the older Go 1.27 integration call site and platform stubs, pin the backend fix, and regenerate vendor and crypto integration patches with their index. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 28, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Obsolete OpenSSL checksum entries in cryptobackend/go.sum produce a nonempty go mod tidy diff, causing TestXCryptoDependencyIsSynced to fail.
No open issues 🎉
What changed in this PR
Backports provider-aware ML-DSA external-mu support to the Microsoft build of Go 1.27, preserving native ML-DSA while using the cached Go-key fallback when external-mu operations are unsupported.
Changes:
- Checks external-mu support for the key’s parameter set and updates all platform shims.
- Upgrades the OpenSSL dependency and regenerates vendored code.
- Updates the standard-library signing call site and patch index.
Patches are happy!
| File | Description |
|---|---|
patches/index.json |
Refreshes patch hashes and index metadata. |
patches/0002-Add-crypto-backends.patch |
Passes key parameters to the signing capability check. |
patches/0001-Vendor-external-dependencies.patch |
Updates vendored OpenSSL code, backend shims, and dependency metadata. |
cryptobackend/mldsa/nobackend.go |
Updates the unavailable-backend stub signature. |
cryptobackend/mldsa/mldsa_windows.go |
Updates the Windows capability signature. |
cryptobackend/mldsa/mldsa_openssl.go |
Delegates capability checks to the OpenSSL provider probe. |
cryptobackend/mldsa/mldsa_darwin.go |
Updates the Darwin capability signature. |
cryptobackend/go.sum |
Adds checksums for the updated OpenSSL dependency. |
cryptobackend/go.mod |
Pins the provider-aware OpenSSL revision. |
Review effort: Balanced
Pin the backport from go-crypto-openssl#109 instead of mainline #108. Regenerate vendor patch 0001 and its index, removing unrelated mainline-only native-loader changes from this release backport. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run the backend's go generate workflow to remove obsolete OpenSSL checksums and satisfy TestXCryptoDependencyIsSynced. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
approved these changes
Oct 28, 2026
Use ms-go1.27-support merge commit 38f583a66fdf from go-crypto-openssl#109, tidy backend dependencies with go generate, and regenerate vendor metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
George Adams (gdams)
enabled stacked auto-merge
October 28, 2026 13:25
George Adams (gdams)
merged commit Oct 28, 2026
eb5c543
into
microsoft/release-branch.go1.27
64 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native validation stack
Bottom layer of stack #2666, landing on
microsoft/release-branch.go1.27: this provider-aware ML-DSA fix → Azure Linux 4 matrix #2665. Auto-merge is disabled; use the native stack merge flow.Summary
Backport provider-aware ML-DSA external-mu support to Go 1.27.
Uses merged microsoft/go-crypto-openssl#109, pinned to support-branch merge SHA
38f583a66fdfb9bfa8135f775b42094efb19980b(v0.5.1-0.20261028132133-38f583a66fdf).SupportsExternalMu(params)on all platforms/stubs and pass the backend key’s parameters at the signing call site.Go 1.26 has no ML-DSA package/backend integration, so no Go 1.26 counterpart is needed.
The dependency is built from
ms-go1.27-supportplus the focused external-mu backport, not OpenSSL main. The OpenSSL support-branch PR is merged. The pinned support-branch build was revalidated against actual Azure Linux 4 SymCrypt.Validation
TestExternalMucases pass with cgo enabled and disabled.crypto/mldsatests andgo/build.TestDependenciespass.OPENSSL_FORCE_FIPS_MODE=1) with both cgo settings.git go-patch extract, preserving the existing patch ownership conventions.