Skip to content

[release-branch.go1.27] Respect OpenSSL ML-DSA external-mu capabilities #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
George Adams (gdams) merged 4 commits into from
Oct 28, 2026
Merged

[release-branch.go1.27] Respect OpenSSL ML-DSA external-mu capabilities #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e832c3
[release-branch.go1.27] Respect OpenSSL ML-DSA external-mu capabilities
gdams Oct 28, 2026
d959465
Use OpenSSL Go 1.27 support-branch external-mu fix
gdams Oct 28, 2026
053965f
Tidy Go 1.27 backend dependency checksums
gdams Oct 28, 2026
ed80db9
Pin merged OpenSSL Go 1.27 support fix
gdams Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cryptobackend/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.26

require (
github.com/microsoft/go-crypto-darwin v0.0.3-0.20261026090017-171c4346c8c7
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261023082322-de7f49aabb03
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261028132133-38f583a66fdf
github.com/microsoft/go-crypto-winnative v0.0.0-20261026100005-aa3b480dc528
golang.org/x/crypto v0.52.1-0.20260526024921-9beb694f9766
)
4 changes: 2 additions & 2 deletions cryptobackend/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
github.com/microsoft/go-crypto-darwin v0.0.3-0.20261026090017-171c4346c8c7 h1:KqCuZFj0Vtzr+BYP7g4CiIuyoaOdIs+qRrLQiznTIJ4=
github.com/microsoft/go-crypto-darwin v0.0.3-0.20261026090017-171c4346c8c7/go.mod h1:Qk7P66UNeurLdefRFjOLOra7dGK2KDwI7zV19wUqNSc=
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261023082322-de7f49aabb03 h1:pHCpigVqj9DspcInT+XANblHy9d/Uwsu1cayD8hqAas=
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261023082322-de7f49aabb03/go.mod h1:rdSY8BhWs3fySEKPnwYbTbCAWxnXQAfrE8qBibXNU/M=
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261028132133-38f583a66fdf h1:hhL3TikHcamwrgp294APQLBQPmlNtuV7ciDhlNFXtfo=
github.com/microsoft/go-crypto-openssl v0.5.1-0.20261028132133-38f583a66fdf/go.mod h1:rdSY8BhWs3fySEKPnwYbTbCAWxnXQAfrE8qBibXNU/M=
github.com/microsoft/go-crypto-winnative v0.0.0-20261026100005-aa3b480dc528 h1:QmorYKlMOWwpmgiFuXU/kQQY+qkC0V/3BvdZm+xR4I8=
github.com/microsoft/go-crypto-winnative v0.0.0-20261026100005-aa3b480dc528/go.mod h1:a1Z07CJIuWa8WT/pzFIGNTTKS96s8o1B1TPOziAHUxw=
golang.org/x/crypto v0.52.1-0.20260526024921-9beb694f9766 h1:ABD+jVg0H4Hwu2sGcUtKeb3T8mlS+jS3uWrkTAPcXjs=
Expand Down
2 changes: 1 addition & 1 deletion cryptobackend/mldsa/mldsa_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func MLDSA44() Parameters { return Parameters{} }
func MLDSA65() Parameters { return xcrypto.MLDSA65() }
func MLDSA87() Parameters { return xcrypto.MLDSA87() }
func Supports(params Parameters) bool { return xcrypto.SupportsMLDSA(params) }
func SupportsExternalMu() bool { return false }
func SupportsExternalMu(params Parameters) bool { return false }
func GenerateKey(params Parameters) (*PrivateKey, error) { return xcrypto.GenerateKeyMLDSA(params) }
func NewPrivateKey(params Parameters, seed []byte) (*PrivateKey, error) {
return xcrypto.NewPrivateKeyMLDSA(params, seed)
Expand Down
12 changes: 7 additions & 5 deletions cryptobackend/mldsa/mldsa_openssl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ type Parameters = openssl.MLDSAParameters
type PrivateKey = openssl.PrivateKeyMLDSA
type PublicKey = openssl.PublicKeyMLDSA

func MLDSA44() Parameters { return openssl.MLDSA44() }
func MLDSA65() Parameters { return openssl.MLDSA65() }
func MLDSA87() Parameters { return openssl.MLDSA87() }
func Supports(params Parameters) bool { return openssl.SupportsMLDSA(params) }
func SupportsExternalMu() bool { return true }
func MLDSA44() Parameters { return openssl.MLDSA44() }
func MLDSA65() Parameters { return openssl.MLDSA65() }
func MLDSA87() Parameters { return openssl.MLDSA87() }
func Supports(params Parameters) bool { return openssl.SupportsMLDSA(params) }
func SupportsExternalMu(params Parameters) bool {
return openssl.SupportsMLDSAExternalMu(params)
}
func GenerateKey(params Parameters) (*PrivateKey, error) { return openssl.GenerateKeyMLDSA(params) }
func NewPrivateKey(params Parameters, seed []byte) (*PrivateKey, error) {
return openssl.NewPrivateKeyMLDSA(params, seed)
Expand Down
2 changes: 1 addition & 1 deletion cryptobackend/mldsa/mldsa_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func MLDSA44() Parameters { return cng.MLDSA44()
func MLDSA65() Parameters { return cng.MLDSA65() }
func MLDSA87() Parameters { return cng.MLDSA87() }
func Supports(params Parameters) bool { return cng.SupportsMLDSA() }
func SupportsExternalMu() bool { return true }
func SupportsExternalMu(params Parameters) bool { return true }
func GenerateKey(params Parameters) (*PrivateKey, error) { return cng.GenerateKeyMLDSA(params) }
func NewPrivateKey(params Parameters, seed []byte) (*PrivateKey, error) {
return cng.NewPrivateKeyMLDSA(params, seed)
Expand Down
2 changes: 1 addition & 1 deletion cryptobackend/mldsa/nobackend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func MLDSA65() Parameters { panic("cryptobackend:
func MLDSA87() Parameters { panic("cryptobackend: not available") }
func (params Parameters) String() string { panic("cryptobackend: not available") }
func Supports(params Parameters) bool { panic("cryptobackend: not available") }
func SupportsExternalMu() bool { panic("cryptobackend: not available") }
func SupportsExternalMu(params Parameters) bool { panic("cryptobackend: not available") }
func GenerateKey(params Parameters) (*PrivateKey, error) { panic("cryptobackend: not available") }
func NewPrivateKey(params Parameters, seed []byte) (*PrivateKey, error) {
panic("cryptobackend: not available")
Expand Down
Loading
Loading