Browser: Remove duplicate border in Modern UI - #335463
Merged
Lee Murray (mrleemurray) merged 2 commits intoSep 10, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 10, 2026 12:29
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Kyle Cutler (@kycutler)Matched files:
Joaquín Ruales (@jruales)Matched files:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Pixel expansion must preserve zero-sized panes to prevent native-view bleed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the redundant integrated Browser boundary when Modern UI’s editor card supplies it.
Changes:
- Conditionally reserves Browser border padding.
- Adds host-pixel snapping for fractional zoom.
- Adds focused layout regression coverage.
File summaries
| File | Description |
|---|---|
webContentsViewRendererFeature.ts |
Updates padding and pixel-snapping behavior. |
webContentsViewRendererFeature.test.ts |
Tests UI modes and fractional zoom. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 10, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Sep 10, 2026
| const snappedAbsoluteTop = snapDown(absoluteTop); | ||
| return { | ||
| ...current, | ||
| width: coverAvailableArea && current.width !== 0 ? snapUp(absoluteLeft + current.width) - snappedAbsoluteLeft : snapDown(current.width), |
Collaborator
There was a problem hiding this comment.
Why was this rounding changed? Rounding up causes the browser to overflow the available area in certain cases (whereas rounding down leaves a bit of extra margin in those cases which is generally preferable).
Comment on lines
-94
to
-102
| // Snap CSS-pixel values down so `v × hostZoom` is an exact integer: | ||
| // main places the WCV at `round(v × hostZoom) × systemDPR` physical | ||
| // pixels while CSS renders it at `v × hostZoom × systemDPR`, so this | ||
| // collapses main's rounding to a no-op and keeps the WebContentsView | ||
| // aligned with the placeholder screenshot. We snap the absolute | ||
| // origin (pane origin + local offset) then derive the corresponding | ||
| // local position so the DOM element and the WCV land on the same | ||
| // physical pixel. Runs late so it refines whatever sizing upstream | ||
| // contributions (e.g. device emulation) produced. |
Collaborator
There was a problem hiding this comment.
This comment gives really important context and shouldn't have been removed
Collaborator
|
Heads-up to some issues with this:
I'm also not a fan of the page jumping when shared, but this is more minor so could be left for feedback |
Contributor
Author
|
Thanks for the feedback - I think we should revert for now & revisit later #335487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run compile./scripts/test.sh --runGlob '**/webContentsViewRendererFeature.test.js'Fixes #327036
Before / After
Both captures use the Browser welcome page, Dark Modern, Modern UI enabled, a 1440×900 window, zoom level 0, hidden sidebars/panel, and the focused URL field.