Revert "Browser: Remove duplicate border in Modern UI" - #335487
Merged
Lee Murray (mrleemurray) merged 1 commit intoSep 10, 2026
Merged
Lee Murray (mrleemurray) merged 1 commit into
Lee Murray (mrleemurray) merged 1 commit into
Conversation
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 10, 2026 15:44
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Kyle Cutler (@kycutler)Matched files:
Joaquín Ruales (@jruales)Matched files:
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Native WebContentsView layout is visually sensitive and this revert knowingly restores the previously reported Modern UI double border.
Pull request overview
Reverts #335463, restoring the integrated browser’s previous WebContentsView layout behavior.
Changes:
- Restores fixed border padding and floor-based pixel snapping.
- Removes Modern UI-specific layout handling and its regression tests.
File summaries
| File | Description |
|---|---|
webContentsViewRendererFeature.ts |
Restores the previous native browser layout logic. |
webContentsViewRendererFeature.test.ts |
Removes tests specific to the reverted behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roblourens
approved these changes
Sep 10, 2026
Kyle Cutler (kycutler)
approved these changes
Sep 10, 2026
Lee Murray (mrleemurray)
deleted the
revert-335463-agents/fix-double-border-modern-ui-browser-editor
branch
September 10, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #335463