Skip to content

Fix default providers query direction - #1659

Open
deem0n wants to merge 1 commit into
moosetechnology:developmentfrom
deem0n:fix-default-providers-query
Open

deem0n wants to merge 1 commit into
moosetechnology:developmentfrom
deem0n:fix-default-providers-query

Conversation

@deem0n

@deem0n deem0n commented Sep 20, 2026

Copy link
Copy Markdown

MiApplication>>defaultProvidersQuery currently evaluates allClients, so a Butterfly map using the default settings shows incoming clients on both sides. For a chain client → central → provider, the right-hand providers query incorrectly returns client.

Change the providers query to evaluate allProviders; leave defaultClientsQuery unchanged. Add a regression test using real Famix Smalltalk methods and invocations to assert both query directions.

Validation in an isolated Moose 13 / Pharo 13 image:

  • The new regression test fails with the original implementation (one failure, no errors).
  • With the fix, MiApplicationTest, MiButterflyMapModelTest, and MiButterflyMapBrowserTest report 50 passed, two skipped, no failures or errors.
  • git diff --check passes.

Discovered while visualizing a PostgreSQL FAMIX model; the fix and test are independent of FAMIXNGSQL. Fork CI could not be dispatched because GitHub has not exposed the fork's workflows; upstream CI results are pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant