Repository navigation
chore: prepare v0.11.0 - #2239
Merged
Merged
Conversation
mxinden
requested review from
KershawChang,
larseggert and
martinthomson
as code owners
November 19, 2024 08:28
KershawChang
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 112 112
Lines 36593 36593
=======================================
Hits 34903 34903
Misses 1690 1690 ☔ View full report in Codecov by Sentry. |
larseggert
approved these changes
Nov 19, 2024
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Member
Author
|
mozilla-central depends on The latest version of
Given that mozilla-central still uses Moving to draft for now, until I figure out a way forward. |
mxinden
marked this pull request as draft
November 19, 2024 08:56
Contributor
Benchmark resultsPerformance differences relative to 998571d. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.163 ns 99.494 ns 99.828 ns]
change: [-6.8676% -2.3477% +0.5382%] (p = 0.35 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.28 ns 117.64 ns 118.04 ns]
change: [-0.8045% -0.4771% -0.0795%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.06 ns 117.66 ns 118.32 ns]
change: [-1.5010% -0.8145% -0.2345%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: 💚 Performance has improved. time: [97.472 ns 97.621 ns 97.787 ns]
change: [-2.8047% -1.9205% -1.0299%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.84 ms 111.90 ms 111.95 ms]
change: [-0.0653% +0.0012% +0.0632%] (p = 0.97 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4941 µs 5.6429 µs 5.7931 µs]
change: [-15.922% -1.1663% +17.731%] (p = 0.87 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [24.763 ms 25.849 ms 26.943 ms]
change: [-10.694% -5.2797% +0.3671%] (p = 0.07 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [32.797 ms 34.495 ms 36.219 ms]
change: [-10.784% -4.1475% +2.9479%] (p = 0.25 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [24.972 ms 25.635 ms 26.303 ms]
change: [-4.8731% -0.5529% +3.6871%] (p = 0.81 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.561 ms 41.669 ms 43.828 ms]
change: [-9.0484% -2.0661% +5.6929%] (p = 0.57 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💔 Performance has regressed. time: [914.65 ms 923.63 ms 932.76 ms]
thrpt: [107.21 MiB/s 108.27 MiB/s 109.33 MiB/s]
change:
time: [+2.9409% +4.4309% +6.0156%] (p = 0.00 < 0.05)
thrpt: [-5.6743% -4.2429% -2.8569%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [322.50 ms 325.85 ms 329.28 ms]
thrpt: [30.369 Kelem/s 30.689 Kelem/s 31.008 Kelem/s]
change:
time: [+0.9474% +2.3903% +3.8471%] (p = 0.00 < 0.05)
thrpt: [-3.7046% -2.3345% -0.9385%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [33.686 ms 33.804 ms 33.921 ms]
thrpt: [29.480 elem/s 29.582 elem/s 29.686 elem/s]
change:
time: [-0.9927% -0.2857% +0.3519%] (p = 0.42 > 0.05)
thrpt: [-0.3506% +0.2865% +1.0027%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.7033 s 1.7216 s 1.7400 s]
thrpt: [57.470 MiB/s 58.085 MiB/s 58.709 MiB/s]
change:
time: [+2.0733% +3.6415% +5.2649%] (p = 0.00 < 0.05)
thrpt: [-5.0016% -3.5135% -2.0312%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Collaborator
|
Sounds like we need to pin |
Member
Author
|
Waiting for https://phabricator.services.mozilla.com/D229493 to land, updating |
mxinden
marked this pull request as ready for review
November 27, 2024 19:49
mxinden
enabled auto-merge
November 27, 2024 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New release to get #2237 into mozilla-central.
Minor bump (
v0.10.0->v0.11.0) due to #2216.