Repository navigation
Conversation
Add contributed base classes to nxclasses via get_contributed_base_classes() and a 'contributed' keyword in get_base_classes(). Let lint_nxdl find and lint base classes in the contributed definitions, warning that they are contributed. Warn when a group used by an application definition is not allowed in its parent by the base class, and add inspect_application(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rayosborn
deleted the
contributed-base-classes-and-inspect-application
branch
October 14, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base classes in
contributed_definitionsare now added tonxclasses, and application validation warns when a definition uses a group its parent base class does not allow.Summary
get_contributed_base_classes()returns the contributed definitions withcategory="base".get_base_classes()appends them after the standard classes, andcontributed=Falserestores the old list.lint_nxdl()finds and lints contributed base classes (e.g.NXgoniometer) with a warning that they are contributed, instead of reporting an error. Messages without a line number no longer show a bracketed location innxlint.GroupValidator.check_in_parent()holds this check and the base-class check uses it too, so its output is unchanged.inspect_application()prints the highlighted NXDL file of an application definition, likeinspect_base_class().NXgoniometer.nxdl.xmlto the contributed definitions.Tests
check_in_parent()and the application base-class warning.