Repository navigation
Container metadata, conda lock files and container configs for all local modules - #97
Merged
Merged
Conversation
…cal modules; set manifest.diagram
|
MaximilianStammnitz
enabled auto-merge
October 29, 2026 21:34
BenjaminWehnert1008
approved these changes
Oct 30, 2026
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes review point 3 (#54): container configs for the local modules.
nf-core modules containers create(tools 4.2.1) for all 26 local modules: Docker and Singularityimages for amd64 and arm64, conda lock files and the
containers:section in eachmeta.yml.Modules with identical
environment.ymlshare one image (10 distinct images in total).conf/containers_*.configregenerated: they now list all local processes.RUN_DIMSUM: stays on its existing image from Release review fixes: samplesheet and parameters (#82), counting, read merging, publishing and docs #84. The new pixi-based builds lack GenomeInfoDbData,whose data a conda post-link script installs, so DiMSum failed. No arm64 or oras entries for it. The conda lock files come from the new build and are untested in CI.
RUN_MUTSCAN: no arm64 images, because bioconductor-mutscan isn't packaged for linux-aarch64.Noted in
docs/usage.md.manifest.diagramset to the metro map (removes the lint warning).Tests: nf-test 3/3 passed locally (Docker, Nextflow 25.10.4) against the unchanged snapshot;
nf-core pipelines lint --release: 0 failures (warnings: Zenodo placeholder, newer nf-core module versions).