Compiler warnings #778

Activity

1. e-perl-NOAA

   added this to the 3.30.26 milestone on Jul 23, 2026
2. e-perl-NOAA

   assigned

   Rick-Methot-NOAA

   on Jul 23, 2026
3. e-perl-NOAA

   added

   change loguse for issues that should appear in change loguse for issues that should appear in change log

   on Jul 23, 2026
4. e-perl-NOAA

   added this to ss3 change logand ss3-issue-trackeron Jul 23, 2026
5. e-perl-NOAA

   added the

   Task

   issue type on Jul 23, 2026
6. e-perl-NOAA

   added

   compiler

   warnings

   on Jul 23, 2026
7. Rick-Methot-NOAA commented on Jul 23, 2026

   

   Rick-Methot-NOAA

   on Jul 23, 2026

   Last edited by Rick-Methot-NOAA

   Collaborator

   More actions

   Thanks to @jimianelli for finding these code issues

   • There are 50 instances that use sprintf that could be replaced by str. Most are in readcontrol. This is optional:

   sprintf(onenum, "%d", F_std_multi);
   to
   onenum = str(F_std_multi);
   

   • Then in readcontrol there are 4 instances where the placement of the ) is incorrect in lines that invoke density-dependence. For example,

   change:  else if (abs(MGparm_1(j, 8) > 0)) //  density-dependence
   to:          else if (abs(MGparm_1(j, 8)) > 0) //  density-dependence
   

   These should be corrected and tested with a model that uses a density-dependent parameter.

   • extra () here: else if( (Comp_Err_L(0, f)==3)) // MV Tweedie
   • suggest adding this to prevent NAN: LinfR = posfun(LinfR, 1.0e-9, CrashPen);
8. Rick-Methot-NOAA

   added a sub-issue on Jul 27, 2026

   • [Bug]: error in invoking density-dependence #779
9. Rick-Methot-NOAA

   modified the milestones: 3.30.26, 3.30.25.1 on Jul 28, 2026
10. Rick-Methot-NOAA

    added

    misc. internal calc

    and removed

    compiler

    on Jul 29, 2026
11. iantaylor-NOAA commented on Jul 30, 2026

    

    iantaylor-NOAA

    on Jul 30, 2026

    Contributor

    More actions

    I believe that this issue was resolved by changes in the associated PRs: #781, #775, and maybe #779.
12. iantaylor-NOAA

    closed this as completedon Jul 30, 2026
13. github-project-automation

    moved this to Done in ss3 change logon Jul 30, 2026
14. github-project-automation

    moved this to Done in ss3-issue-trackeron Jul 30, 2026