Skip to content

[Bug]: error in invoking density-dependence #779

Closed

Description

@Rick-Methot-NOAA

Describe the bug

parent issue #778 included an error in () for setting up density-dependent parameters.
A test with the current code (3.30.25) confirmed that density-dependence was not happening for a MGparm.
With this control.ss line:

# Sex: 1  BioPattern: 1  Growth
 -10 45 21.6591 36 10 6 2 -203 0 0 0 0 0 0 # L_at_Amin_Fem_GP_1

The echoinput showed:

timevary for MG parameter: 2
baseparm:  -10 45 21.6591 36 10 6 2 -203 0 0 0 0 0 0
env link_type: 2 env_var: 0
 do env additive 
timevary_setup 1 2 1 0 0 2 0 0 0 0 0 0 2 0
Display timevary_MG flag
1970 timevary_MG:  0 0 0 0 0 0 0 0
1971 timevary_MG:  0 0 0 0 0 0 0 0

And the parameter stayed constant over time.

To Reproduce

set as shown above

Expected behavior

quantity calculated from the parameter should have been time varying.

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

3.30.25 and probably several earlier versions

Additional Context

No response

Activity

  1. added this to the 3.30.26 milestone on Jul 27, 2026
  2. Rick-Methot-NOAA commented on Jul 27, 2026

    @Rick-Methot-NOAA
    CollaboratorAuthor

    With the change as recommended in the compiler warnings issue, the problem is rectified.
    The echoinput now shows the dens-dep being invoked:

     timevary for MG parameter: 2
    Density-dependent flag for MGparms 1 MGparm: 2
    baseparm:  -10 45 21.6591 36 10 6 2 -203 0 0 0 0 0 0
    env link_type: 2 env_var: -3
     do env additive 
    timevary_setup 1 2 1 0 0 2 -3 0 0 0 0 0 2 0
    Display timevary_MG flag
    1970 timevary_MG:  0 0 0 0 0 0 0 0
    1971 timevary_MG:  1 0 1 0 0 0 0 0
    1972 timevary_MG:  1 0 1 0 0 0 0 0
    1973 timevary_MG:  1 0 1 0 0 0 0 0
    .....
    

    and report.sso shows the expected result (decline in Lmin as summary_biomass declines over time)

    MGparm_By_Year_after_adjustments report:7
    Yr   Change?  NatM_uniform_Fem_GP_1 L_at_Amin_Fem_GP_1 L_at_Amax_Fem_GP_1  ....
    1971 1  0.1 21.6591 71.654 ....
    1972 1  0.1 21.6568 71.654 ....
    1973 1  0.1 21.6514 71.654 ....
    1974 1  0.1 21.6389 71.654 ....
    .....
    1998 1  0.1 20.3525 71.654
    
    
  3. Rick-Methot-NOAA commented on Jul 27, 2026

    @Rick-Methot-NOAA
    CollaboratorAuthor

    Also, revise the name for the link parameter to include _DD
    -10 10 1 1 0.5 6 4 # L_at_Amin_Fem_GP_1_ENV_add_DD

  4. moved this to In Progress in ss3-issue-trackeron Jul 28, 2026
  5. moved this to In Progress in ss3 change logon Jul 28, 2026
  6. moved this from In Progress to Done in ss3-issue-trackeron Jul 28, 2026
  7. moved this from In Progress to Done in ss3 change logon Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working; don't remove label after fixingchange loguse for issues that should appear in change logtime-vary parm

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions