Repository navigation
test(coverage): restore per-package coverage floors on main - #1022
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage on main fails the per-package floor step:
internal/nginxtopomeasured 93.5% against a floor of 98% (runs 40746704367, 40856341289). It was the only package below its floor.The uncovered statements were the three error returns in
nginxtopo.Contained: unresolvable project root, a path below a regular file (ENOTDIR), and a self-referencing symlink.TestContained_UnresolvablePathsasserts each one is refused with the expected message, and that the root-missing cause stays in the error chain.Verification, using the commands from coverage.yml:
go test -mod=vendor -coverprofile=coverage.out -covermode=atomic ./...passes. Total is 71.3%.go run -mod=vendor ./tools/covfloor -profile coverage.out -floors .github/coverage-floors.txt -strictreports 172 packages, 0 below floor, with nginxtopo at 100.0%.go build -mod=vendor ./...,go veton the package andgo test ./internal/repoqapass.No floor changed and no code excluded.