Skip to content

Release 1.4.1 - #55

Merged
setoelkahfi merged 2 commits into
developmentfrom
release/1.4.1
Nov 2, 2026
Merged

setoelkahfi merged 2 commits into
developmentfrom
release/1.4.1

Conversation

@setoelkahfi

Copy link
Copy Markdown
Collaborator

Bumps the workspace to 1.4.1. This ships #53 and #54: the path-only ed-acp-testkit dev-dependency that broke the 1.4.0 publish, and the README and license files for ed-claude.

The bump is the workspace version and the eight ed-* path dependencies in the root Cargo.toml, plus the matching Cargo.lock entries.

The second commit adds a note to the release skill: workspace-member dev-deps must be path-only, because cargo-workspaces strips versioned dev-deps and the --locked publish then fails.

Checked locally: cargo fmt --check, cargo test --locked --workspace, cargo clippy --locked --workspace --all-targets -- -D warnings, and cargo package -p ed-claude --locked --list shows README.md, LICENSE-APACHE and LICENSE-MIT.

After merge I'll tag v1.4.1 on the merge commit.

setoelkahfi and others added 2 commits November 2, 2026 14:19
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@setoelkahfi setoelkahfi self-assigned this Nov 2, 2026
@setoelkahfi
setoelkahfi requested a review from paydii November 2, 2026 13:21

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release bump to 1.4.1: the workspace version and the eight ed-* entries in the root [workspace.dependencies] table move to 1.4.1, with the matching Cargo.lock regeneration (not shown). The actual 1.4.0 publish fix — making the ed-acp-testkit dev-dependency path-only in the consuming member — lives in the member manifests outside this diff; the root entry keeping version alongside path is fine, since the skill note correctly targets foo.workspace = true usage in [dev-dependencies], not the workspace table itself. The third commit documents that failure mode in the release skill. Local checks (fmt, test --locked, clippy --locked, cargo package -p ed-claude --locked --list) cover the lockfile consistency and the packaged files, so nothing here looks off for tagging v1.4.1 after merge.


Automated review by siGit Code Review · commit 9aa035e · see the review dashboard

@setoelkahfi
setoelkahfi merged commit 7917edf into development Nov 2, 2026
1 check passed
@setoelkahfi
setoelkahfi deleted the release/1.4.1 branch November 2, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants