Repository navigation
feat(scan): add unified max-time investigation budgets - #1674
mldangelo-oai wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb684c535
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1fb684c to
f8d6983
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8d6983364
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f8d6983 to
d176dcd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b877d5efe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2b877d5 to
12abd7d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12abd7dc57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Add one minutes-based investigation setting across the CLI, SDK, and plugin without changing default scan behavior. This is the runtime foundation; the production-path comparison is isolated in #1679.
Changes
scan --max-time <minutes>, SDKmaxTimeMinutes, and projectscan.max_time_minutes. Standard remains unset by default; Deep retains its existing 5760-minute default and maximum.Testing
build:ci, source compatibility, and its nine tests. Prettier, Markdown checks, andgit diff --checkpass.Risk and rollout
Opt-in only for Standard: no new hard timeout, minimum duration, automatic continuation, or spending guarantee. Deep's coordinator and existing stopping conditions are unchanged. Invalid or unrepresentable deadlines fail before scan setup. Existing cost controls, cancellation, credential protections, permissions, and authorized scope remain intact.
The new setting does not establish improved detection or cost efficiency. No live-model effectiveness claim, run artifacts, or scan findings are included.
Public disclosure review