Repository navigation
test(evals): compare production Standard scan time budgets - #1679
mldangelo-oai wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 453299b0aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e60b241fe3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1fb684c to
f8d6983
Compare
fcdada1 to
972d96c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 972d96c5cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f8d6983 to
d176dcd
Compare
972d96c to
a843299
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a843299654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
18ca884 to
e102079
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e102079737
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e102079 to
710f985
Compare
2b877d5 to
12abd7d
Compare
710f985 to
6dee75e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dee75e349
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6dee75e to
0b8be06
Compare
Summary
Compare production Standard scans with and without an advisory time allowance. Stacked on the runtime support in #1674; this PR contains only evaluation code, fixtures, documentation, and test/build wiring.
Changes
CodexSecurity.run, including real prompt construction, canonical artifact validation, completion, and delegated-worker usage accounting. Only the treatment setsmaxTimeMinutes.root_controlorsinkcitation; retain other-role findings and control overlaps for manual adjudication rather than automatically crediting or labeling them false positives.Testing
build:plugin,build:evals, SDK types, Prettier/Markdown checks, andgit diff --checkpass.supporting_contextevidence for automatic recall, preserve known primary-role credit and descriptive safe-control advisories, and verify evaluator/shared-helper changes alter provenance while generated reports do not.Risk and rollout
The evaluator is opt-in and requires an existing
OPENAI_API_KEYorCODEX_API_KEY, with no effect on production CLI/SDK/plugin login or runtime defaults. Live model runs consume usage and have no enforced time or spending cap. Generated artifacts stay ignored and are not included in this PR.The small synthetic corpus is a smoke comparison, not evidence of real-world effectiveness. Source matching is heuristic; adjudicate findings and compare recall, false positives, completion, tokens, and elapsed time together. The arms are not spend-matched, and missing usage must remain unknown rather than zero.
Public disclosure review