Repository navigation
Add "guestlinks" authmanager - #822
Merged
Merged
Conversation
rhafer
force-pushed
the
cookie-auth
branch
2 times, most recently
from
September 28, 2026 12:34
230b272 to
6959f58
Compare
Member
Author
|
Streamlined the expected JWT claims with the related opencloud PR (opencloud-eu/opencloud#3609) |
rhafer
marked this pull request as ready for review
September 30, 2026 13:49
Add an opt-in StatusInnerErrorProvider interface (pkg/rgrpc/status) so auth manager errors can attach details to rpc.Status.InnerError. Only errors implementing (or wrapping) the interface contribute details; nothing is serialized automatically. - authprovider service: attach InnerError when the auth error provides one. - gateway Authenticate: also pass CODE_UNAVAILABLE through unchanged (alongside existing UNAUTHENTICATED/PERMISSION_DENIED/NOT_FOUND), preserving Message, Trace and InnerError. This is needed groundwork the upcoming guestlinks auth manager. It needs to be able to return additional details when used authentication token is expired.
rhafer
force-pushed
the
cookie-auth
branch
3 times, most recently
from
October 1, 2026 13:35
4ad6938 to
cd19a6d
Compare
Add a new "guestlinks" Reva authentication manager that validates OpenCloud guest-link session JWTs. Related: opencloud-eu/opencloud#3070
Consistently map the `InvalidCredentials` error to the `Unauthenticated` Status, like the other mappers already do (e.g. from/to HTTP Status code or the one via the `IsInvalidCredentials` interface).
Make errtype marker interfaces implement error, then use them consistently when converting errors to RPC statuses.
aduffeck
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add a new authmanager allowing to sign reva tokes for the upcoming guestlinks implemenation (needed for: opencloud-eu/opencloud#3070)
It also streamlines the errtypes <-> statuscode mapping. I can put that into a separate PR if desired.