Repository navigation
Conversation
- State rules rather than one-off decisions from opengeos#862: drop the contributor credit, the Directions exception and the Go To XY ruling; interim exceptions are recorded in the issue that tracks the move. - Add "labels say what happens", with Go To XY as its example. - Split the PR checklist: adding a control needs its task, tab, how it opens and a screenshot; moves and removals also need the remaining route and the workflow comparison. - Check width at 1366 px instead of "laptop width". - Mark the layer chooser as planned. - Use Select, which is a split button today, as the split-button example. - Point AGENTS.md at the guidelines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Code reviewThis PR only changes documentation: What I checked
BugsNone found. SecurityNone found. PerformanceNot applicable. Quality
AGENTS.mdNo violations. The PR adds no code, assets or dependencies, and the quality gates for code don't apply. Change sizeCompared: the whole PR against update-docs-ribbon-guidelines (merge base 7d6b909 to PR head 0539278)
|
dbb4759
into
opengeos:update-docs-ribbon-guidelines
* docs: define ribbon design and contribution guidelines * docs: tighten the ribbon guidelines into lasting rules (#904) --------- Co-authored-by: Mavrick Fitzgerald <MavrickFitzgerald@gmail.com>
Summary
Follow-up to #903, stacked on its branch. It keeps the guidelines and tab purposes from #862, and makes them rules that won't go stale as those decisions land:
Documentation only; no ribbon controls, command ids or parameters change.
Testing
zensical build: no issues found.SKIP=cargo-fmt,cargo-clippy pre-commit runon the changed files: passed.cargo xtask ciwas not run: only Markdown changed, so its fmt, clippy, test and layer checks have nothing new to check. CI on this PR runs them.Related issue
Stacked on #903; follows discussion #862.
🤖 Generated with Claude Code