Skip to content

Fail closed in DAG postprocessing - #197

Merged
oshaughn merged 1 commit into
oshaughn:rift_O4cfrom
oshaughnessy-junior:fix/consolidate-postprocess-path-o4c
Sep 26, 2026
Merged

oshaughn merged 1 commit into
oshaughn:rift_O4cfrom
oshaughnessy-junior:fix/consolidate-postprocess-path-o4c

Conversation

@oshaughnessy-junior

@oshaughnessy-junior oshaughnessy-junior commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • resolve ILE and NR postprocessing helpers relative to the installed wrapper, with a guarded PATH fallback
  • propagate cleaner, sort, and relabel pipeline failures instead of accepting empty products
  • require nonempty composite and indexed outputs before packaging success
  • add sanitized-PATH regression coverage for missing helpers, sibling resolution, helper failures, and empty outputs

Production motivation

Calibration reruns exposed a fail-open path: util_ILEdagPostprocess.sh was invoked by absolute path, but its bare util_CleanILE.py call was absent from the worker PATH. The wrapper still returned zero and left an empty consolidated_N.composite, so failure appeared only in a later DAG POST check.

This patch does not hardcode any production environment path or alter DAG science configuration.

Testing

  • bash -n on both modified wrappers
  • pytest -q MonteCarloMarginalizeCode/Code/test/test_dag_postprocess_fail_closed.py (6 passed)

This is the O4c half of a coordinated O4c/O4d fix. Paired O4d PR: oshaughnessy-junior#373

@oshaughnessy-junior
oshaughnessy-junior had a problem deploying to private-review-dispatch-rift-upstream September 21, 2026 09:17 — with GitHub Actions Failure
@oshaughn
oshaughn merged commit a8c221e into oshaughn:rift_O4c Sep 26, 2026
1 of 2 checks passed
@oshaughn
oshaughn deployed to private-review-dispatch-rift-upstream September 26, 2026 17:44 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
private-review-dispatch-rift-upstream — 02c2c6da Deployed Sep 26, 2026 by oshaughn via Dispatch exact upstream RIFT PR generation #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants