Fail closed in DAG postprocessing - #373
Open
oshaughnessy-junior wants to merge 2 commits into
Open
oshaughnessy-junior wants to merge 2 commits into
oshaughnessy-junior wants to merge 2 commits into
Conversation
oshaughnessy-junior
had a problem deploying
to
private-review-dispatch-rift
September 21, 2026 09:17 — with 
GitHub Actions
Failure
GitHub Actions
Failure
oshaughnessy-junior
had a problem deploying
to
private-review-dispatch-rift
September 21, 2026 09:20 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATHfallbackPATHregression coverage for missing helpers, sibling resolution, helper failures, and empty outputsProduction motivation
Calibration reruns exposed a fail-open path:
util_ILEdagPostprocess.shwas invoked by absolute path, but its bareutil_CleanILE.pycall was absent from the workerPATH. The wrapper still returned zero and left an emptyconsolidated_N.composite, so failure appeared only in a later DAG POST check.This patch preserves the newer O4d hyperpipeline and dynamic sort-key behavior. It does not hardcode any production environment path or alter DAG science configuration.
Testing
bash -non both modified wrapperspytest -q MonteCarloMarginalizeCode/Code/test/test_dag_postprocess_fail_closed.py(6 passed)This is the O4d half of a coordinated O4c/O4d fix. Paired O4c PR: oshaughn#197