Repository navigation
release: drop releasetargets left pointing at the deleted project - #205
Merged
Merged
Conversation
OBS rewrites references to a force-deleted project to project="deleted". A hop-1 release target left on a staging project by a cancelled populate became such a target once sync prerelease deleted the old pre-release tree, and osc release then failed with "no permission to write in project deleted". _remove_release_targets (the self-heal run before every osc release) now also drops targets in the deleted project, so the next populate repairs the source project. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The boo populate of #201 (run 41127102551) failed for
ppg:releases:18:The earlier cancelled run 41062930990 left hop-1 release targets on
isv:percona:ppg:staging:18(all 10 repos) pointing atPR:pr-201:ppg:releases:18. Since #204,sync prereleaseforce-deletes the old pre-release tree, and OBS rewrites references to a force-deleted project as<releasetarget project="deleted" repository="deleted"/>. The self-heal beforeosc releaseonly removed targets matching the pre-release name, so the rewritten ones stayed andosc releasetried to write intodeleted.Change
_remove_release_targets(run before and after everyosc release) also drops targets in thedeletedproject — they can never be valid. The next populate repairs productionstaging:18by itself; no manual meta edit needed.Tests
deletedand own targets removed, unrelated target keptpytest tests753 passed; black + pyright clean