Skip to content

Sql lint fixes: named literal arguments, isset, empty and elvis #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mundy merged 3 commits into from
Oct 6, 2026
Merged

Sql lint fixes: named literal arguments, isset, empty and elvis #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a437620
Name literal arguments and replace isset, empty and elvis in Sql
simon-mundy Oct 4, 2026
e182bd3
Exit the specification loop early in createSqlFromSpecificationAndPar…
simon-mundy Oct 4, 2026
0bf51ea
Merge branch '0.6.x' into qa/mago-sql-lint
simon-mundy Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions analyzer-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ count = 1
file = "src/Sql/AbstractSql.php"
code = "mixed-argument"
message = "Invalid argument type for argument #1 of `vsprintf`: expected `string`, but found `mixed`."
count = 2
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
Expand Down Expand Up @@ -2004,12 +2004,6 @@ code = "possibly-undefined-string-array-index"
message = "Possibly undefined array key `string('column')` accessed on `array<array-key, mixed>`."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "possibly-undefined-variable"
message = "Variable `$paramSpecs` might not have been defined on all execution paths leading to this point."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "string-member-selector"
Expand Down Expand Up @@ -3522,36 +3516,12 @@ code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Platform\Platform` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "invalid-iterator"
message = "The expression provided to `foreach` is not iterable. It resolved to type `nonnull`, which is not iterable."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-argument"
message = "Invalid argument type for argument #2 of `is_a`: expected `class-string`, but found `mixed`."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-array-assignment"
message = "Unsafe array assignment on type `mixed`."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-assignment"
message = "Assigning `mixed` type to a variable may lead to unexpected behavior."
count = 2

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-method-access"
message = "Attempting to access a method on a non-object type (`mixed`)."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-return-statement"
Expand All @@ -3564,12 +3534,6 @@ code = "mixed-return-statement"
message = 'Could not infer a precise return type for function `PhpDb\Sql\Platform\Platform::getSqlString`. Saw type `mixed`.'
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "mixed-return-statement"
message = 'Could not infer a precise return type for function `PhpDb\Sql\Platform\Platform::getTypeDecorator`. Saw type `mixed`.'
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "non-existent-method"
Expand Down
192 changes: 0 additions & 192 deletions lint-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,24 +354,6 @@ code = "kan-defect"
message = "Class has a high kan defect score."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "literal-named-argument"
message = 'Literal argument `"\n ,"` should be passed as a named argument for clarity.'
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "literal-named-argument"
message = "Literal argument `'%'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "literal-named-argument"
message = "Literal argument `'__'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "no-else-clause"
Expand All @@ -384,36 +366,12 @@ code = "no-else-clause"
message = "Avoid `elseif` clauses."
count = 5

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 5

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "no-shorthand-ternary"
message = "Use of the shorthand ternary operator."
count = 1

[[issues]]
file = "src/Sql/AbstractSql.php"
code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Argument/Identifiers.php"
code = "literal-named-argument"
message = "Literal argument `'%s'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Argument/Values.php"
code = "literal-named-argument"
message = "Literal argument `'%s'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Combine.php"
code = "cyclomatic-complexity"
Expand All @@ -426,24 +384,12 @@ code = "kan-defect"
message = "Class has a high kan defect score."
count = 1

[[issues]]
file = "src/Sql/Combine.php"
code = "literal-named-argument"
message = "Literal argument `' '` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Combine.php"
code = "no-array-accumulation-in-loop"
message = "Array spread in reassignment inside a loop causes O(n²) array copying."
count = 1

[[issues]]
file = "src/Sql/Combine.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "kan-defect"
Expand All @@ -462,30 +408,12 @@ code = "no-else-clause"
message = "Avoid `elseif` clauses."
count = 2

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractLengthColumn.php"
code = "literal-named-argument"
message = "Literal argument `0` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractLengthColumn.php"
code = "literal-named-argument"
message = "Literal argument `2` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractPrecisionColumn.php"
code = "excessive-parameter-list"
Expand All @@ -498,12 +426,6 @@ code = "halstead"
message = "Method has a high halstead difficulty"
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractTimestampColumn.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Column.php"
code = "no-else-clause"
Expand All @@ -516,30 +438,12 @@ code = "no-else-clause"
message = "Avoid `elseif` clauses."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Integer.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/AbstractConstraint.php"
code = "literal-named-argument"
message = "Literal argument `'%s'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "excessive-parameter-list"
message = "Parameter list is too long."
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "literal-named-argument"
message = "Literal argument `'%s'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "cyclomatic-complexity"
Expand All @@ -558,24 +462,12 @@ code = "no-else-clause"
message = "Avoid `elseif` clauses."
count = 2

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Ddl/Index/Index.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Delete.php"
code = "no-else-clause"
Expand All @@ -588,24 +480,6 @@ code = "halstead"
message = "Method has a high halstead difficulty"
count = 1

[[issues]]
file = "src/Sql/Expression.php"
code = "literal-named-argument"
message = "Literal argument `'%%'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Expression.php"
code = "literal-named-argument"
message = "Literal argument `'%s'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Expression.php"
code = "literal-named-argument"
message = "Literal argument `1` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Expression.php"
code = "no-else-clause"
Expand All @@ -630,36 +504,6 @@ code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Join.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 1

[[issues]]
file = "src/Sql/Literal.php"
code = "literal-named-argument"
message = "Literal argument `'%%'` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "literal-named-argument"
message = "Literal argument `''` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "literal-named-argument"
message = "Literal argument `true` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Platform/Platform.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 2

[[issues]]
file = "src/Sql/Predicate/In.php"
code = "halstead"
Expand Down Expand Up @@ -762,18 +606,6 @@ code = "kan-defect"
message = "Class has a high kan defect score."
count = 1

[[issues]]
file = "src/Sql/Select.php"
code = "literal-named-argument"
message = "Literal argument `' as '` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Select.php"
code = "literal-named-argument"
message = "Literal argument `2` should be passed as a named argument for clarity."
count = 1

[[issues]]
file = "src/Sql/Select.php"
code = "no-else-clause"
Expand All @@ -786,24 +618,6 @@ code = "no-else-clause"
message = "Avoid `elseif` clauses."
count = 3

[[issues]]
file = "src/Sql/Select.php"
code = "no-empty"
message = "Use of the `empty` construct."
count = 1

[[issues]]
file = "src/Sql/Select.php"
code = "no-isset"
message = "Use of the `isset` construct."
count = 2

[[issues]]
file = "src/Sql/Select.php"
code = "no-negated-ternary"
message = "Negated ternary condition."
count = 1

[[issues]]
file = "src/Sql/Select.php"
code = "too-many-methods"
Expand All @@ -816,12 +630,6 @@ code = "too-many-properties"
message = "Class has too many properties."
count = 1

[[issues]]
file = "src/Sql/Sql.php"
code = "no-shorthand-ternary"
message = "Use of the shorthand ternary operator."
count = 4

[[issues]]
file = "src/Sql/Update.php"
code = "cyclomatic-complexity"
Expand Down
Loading
Loading