Repository navigation
Sql lint fixes: named literal arguments, isset, empty and elvis - #203
Merged
Merged
Conversation
isset() checks become explicit null comparisons or ??=, so the behaviour for null entries is unchanged. Sql's factory methods switch from ?: to ??, which is equivalent because every constructor already treats a falsy table as no table. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ameters() Clears the prefer-early-continue lint hint raised by the rewritten loop. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
Merged
simon-mundy
added
documentation
tyrsson
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
literal-named-argument,no-isset,no-empty,no-shorthand-ternaryandno-negated-ternaryMago lint findings insrc/Sql, removing 41 lint baseline entries.Changes
str_replace,array_fill,array_splice,trim,explode,stripos,is_a) are passed by name.isset()checks become explicit null comparisons,(... ?? null)checks or??=, so null entries behave as before.empty($this->order)inSelect::processOrder()becomes[] === $this->order.Sql::delete(),insert(),select()andupdate()use??instead of?:. Each constructor already treats a falsy table as no table, so the result is the same.AbstractSql::createSqlFromSpecificationAndParameters()records the matching specification instead ofunset()-ing the loop variables to detect a miss.Platform::getTypeDecorator()reads the platform's decorator map into a local once, instead of re-indexing it for each check.src/Sqlentries change.Breaking changes
None.
mago format,mago lint,mago analyzeand the unit tests pass.