fix(safetensors): preserve native FDICT-shaped headers - #1863
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Performance BenchmarksCompared
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid SafeTensors files with header lengths such as 8,312 bytes start with bytes that also resemble a preset-dictionary zlib stream. Keep native SafeTensors routing when the bounded header parses successfully, so these files receive normal metadata and tensor validation. Unknown extensions, inconclusive headers, and genuine compressed files retain compression routing.
Supersedes #1859, preserving the contributor's commits, synchronizing with main, removing unrelated dependency changes, and expanding regression coverage. Fixes #1854.
Validation:
Current-base verification (2026-09-30): head
25a8996066150e23c17ff63a375ba1d0823f9c48merges cleanly with maine32b430ed2e72c0b0942246634f750af65c818e0. The temporary merged tree passed all 18 FDICT/zlib routing tests, repository-wide Ruff 0.16.9 checks, and mypy 2.3.1 (480 files). The temporary merge was removed after testing; the published head is unchanged and has 23 successful checks plus eight intentional skips. No unresolved review threads were found; required reviewer approval is still pending.