Repository navigation
Let a Manual Dispatch Bypass the Smoke Build's Paths Filter - #3153
Conversation
A workflow_dispatch run has no changed paths to filter, so the paths-filter job reports no release change and the smoke build was always skipped. A manual run is an explicit ask to build, so smoke-build now runs on a dispatch or on a filtered change, in the catalog snippet and its documented copy together. Fixes #3149 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for the manual-dispatch branch of the condition.
1 open finding
What changed in this PR
Updates smoke-build gating so manual dispatches run even when no release paths changed, while pull requests retain path-based filtering.
Changes:
- Adds a
workflow_dispatchbypass to the smoke-build condition. - Synchronizes the catalog snippet and documentation example.
| File | Summary |
|---|---|
catalog/snippets/workflows/test-pull-request-smoke.yml |
Updates the smoke-build dispatch gate. |
docs/reusable-workflows.md |
Mirrors the updated workflow condition. |
🧠 Review effort: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The byte-for-byte test only proved the snippet and its documented copy match, so reverting both to a filter-only condition still passed. It now also asserts the smoke-build condition carries the workflow_dispatch bypass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3153 +/- ##
==========================================
Coverage ? 63.94%
==========================================
Files ? 17
Lines ? 9151
Branches ? 0
==========================================
Hits ? 5852
Misses ? 3299
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
A recorded local strict-review pass covers head |
… Dash-Name Refusal to Main (#3164) - #3162 makes `gh-write-guard` read the gh write targets it still missed: an inherited `GH_REPO` from the session environment, a run-time word before gh's command, a gh write behind a run-time command word, a positional repository and the missing write subcommands, `gh api` write targets outside `repos/`, and the `GH_REPO` gaps #3135 introduced. It adds no new allow. - #3156 makes both bootstrap loaders reject a dash-prefixed `-Agents`/`--agents` name before the handoff, so `-All` can no longer bind install-agents' switch. Verified natively under pwsh 7 and Windows PowerShell 5.1 in #3161. - #3153 lets a manual dispatch bypass the smoke build's paths filter, in the catalog snippet and the reusable-workflows example together. - #3154 tests the Docker task workflow's credential check, login, and hook inputs. - #3150 bumps the actions-deps group. After this merges, the host-safety installer payload changes, so the maintainer runs the installer after promotion. Closes #3129 Closes #3131 Closes #3132 Closes #3133 Closes #3136 Closes #3147 Closes #3148 Closes #3149 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Fixes #3149
The release-with-smoke caller stub gated
smoke-buildonly on the paths-filter output, so aworkflow_dispatchrun (no changed paths) always skipped the build. Per the maintainer decision on the issue,smoke-buildnow runs whengithub.event_name == 'workflow_dispatch' || needs.changes.outputs.release == 'true'. Theworkflow_dispatch:trigger stays. The change is incatalog/snippets/workflows/test-pull-request-smoke.ymland the matching example indocs/reusable-workflows.md, which stay byte-identical.Verification
tests/test_release_guards.py::ReleaseGuardCase::test_smoke_caller_stub_is_its_snippet_byte_for_bytepasses. Revert proof: reverting only the docs copy makes it fail.branchinput resolves viaref_name.🤖 Generated with Claude Code