Skip to content

Let a Manual Dispatch Bypass the Smoke Build's Paths Filter #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 2 commits into from
Oct 16, 2026
Merged

Let a Manual Dispatch Bypass the Smoke Build's Paths Filter #3153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e4b5a
Let a Manual Dispatch Bypass the Smoke Build's Paths Filter
ptr727 Oct 16, 2026
ad96f59
Assert the Smoke Stub's Dispatch Bypass in Its Test
ptr727 Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion catalog/snippets/workflows/test-pull-request-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
smoke-build:
name: Smoke build job
needs: [changes]
if: needs.changes.outputs.release == 'true'
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.release == 'true'
Comment thread
ptr727 marked this conversation as resolved.
uses: ptr727/ProjectTemplate/.github/workflows/build-release-task.yml@6c88850128629bb449fd73c7fbf82968c6cd1557 # 2.0.587
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion docs/reusable-workflows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ jobs:
smoke-build:
name: Smoke build job
needs: [changes]
if: needs.changes.outputs.release == 'true'
if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.release == 'true'
uses: ptr727/ProjectTemplate/.github/workflows/build-release-task.yml@6c88850128629bb449fd73c7fbf82968c6cd1557 # 2.0.587
permissions:
contents: read
Expand Down
4 changes: 4 additions & 0 deletions tests/test_release_guards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,10 @@ def test_smoke_caller_stub_is_its_snippet_byte_for_byte(self) -> None:
blocks = yaml_blocks((REPO / "docs/reusable-workflows.md").read_text(encoding="utf-8"))
self.assertIn(stub, blocks)
self.assertIn("smoke: true", stub)
self.assertIn(
" if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.release == 'true'\n",
stub,
)

def test_release_asset_hook_upload_stays_with_the_task(self) -> None:
workflow = (REPO / ".github/workflows/build-release-task.yml").read_text(encoding="utf-8")
Expand Down
Loading