Fix / search shortcut on shifted layouts and Firefox - #3227
Open
mmustafasenoglu wants to merge 1 commit into
Open
mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
| e.ctrlKey || | ||
| e.metaKey || | ||
| e.shiftKey || | ||
| (e.shiftKey && e.key !== '/') || |
Member
There was a problem hiding this comment.
I think we can remove the shiftKey check completely.
GuillaumeGomez
requested changes
Sep 22, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On layouts like AZERTY where
/needs Shift, the global key handler bailed out one.shiftKeybefore ever checking for/, so search never opened. This exempts/from the Shift guard while still respecting Ctrl/Alt/Meta. Once the shortcut reaches the handler, the existingpreventDefault()also stops Firefox from opening Quick Find instead.Fixes #3199