Skip to content

Fix / search shortcut on shifted layouts and Firefox #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmustafasenoglu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix / search shortcut on shifted layouts and Firefox #3227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/mdbook-html/front-end/searcher/searcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
if (e.altKey ||
e.ctrlKey ||
e.metaKey ||
e.shiftKey ||
(e.shiftKey && e.key !== '/') ||

Check failure on line 360 in crates/mdbook-html/front-end/searcher/searcher.js

View workflow job for this annotation

GitHub Actions / GUI tests 

Unnecessary parentheses around expression

@GuillaumeGomez GuillaumeGomez Sep 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the shiftKey check completely.

View changes since the review

e.target.type === 'textarea' ||
e.target.type === 'text' ||
!hasFocus() && mdbook_something_else_has_focus(e)
Expand Down
Loading