Skip to content

sanitizers: Implement support for the sanitize ignorelist - #157808

Open
1c3t3a wants to merge 1 commit into
rust-lang:mainfrom
1c3t3a:sanitizer-ignorelist
Open

sanitizers: Implement support for the sanitize ignorelist#157808
1c3t3a wants to merge 1 commit into
rust-lang:mainfrom
1c3t3a:sanitizer-ignorelist

Conversation

@1c3t3a

@1c3t3a 1c3t3a commented Jun 12, 2026

Copy link
Copy Markdown
Member

View all comments

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle

@rustbot

rustbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 12, 2026
@rust-log-analyzer

This comment has been minimized.

@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch 2 times, most recently from 624834b to 693e22f Compare June 12, 2026 12:49
@1c3t3a
1c3t3a requested a review from rcvalle June 12, 2026 14:20
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026
@1c3t3a
1c3t3a requested a review from rcvalle June 15, 2026 08:54
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2026
@rust-bors

This comment has been minimized.

Comment thread compiler/rustc_codegen_llvm/src/common.rs Outdated
Comment thread tests/codegen-llvm/sanitizer/ignorelist/cfi-ignorelist.rs
Comment thread compiler/rustc_codegen_llvm/src/llvm/mod.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/attributes.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from a24ff27 to eeed708 Compare August 27, 2026 10:12
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from eeed708 to 066c9e1 Compare August 27, 2026 10:17
@1c3t3a
1c3t3a requested a review from rcvalle August 27, 2026 10:18
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
Rollup of 23 pull requests

Successful merges:

 - #157808 (sanitizers: Implement support for the sanitize ignorelist)
 - #160564 (volatile: allow accesses to non-AM memory to trap)
 - #161579 (suggest calling a fn item used as the iterator of a `for` loop)
 - #162044 (coverage: Resolve spans to file-coordinates in a separate step)
 - #162120 (Introduce `PerOwnerLoweringState`)
 - #162151 (Test itanium mangling of `f16` and `f128`)
 - #162162 (Don't special-case `!` in stability checks anymore)
 - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 )
 - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`)
 - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants)
 - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia)
 - #161847 (Preserve visibility in nested macro import suggestions)
 - #161972 (Improve tests for `#[track_caller]` in async)
 - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery)
 - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`)
 - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`)
 - #162152 (Revert "retrieve supported GCC targets from the sysroot")
 - #162153 (Prefer `LLVMGetVersion` for runtime info)
 - #162168 (fix ICE in project_goals/inherent)
 - #162171 (Explain LoongArch f16 NaN-boxing in inline asm)
 - #162173 (fix supposedly unreachable `bug!` being reachable)
 - #162191 (core: mark float `ClampBounds` methods as `#[inline]`)
 - #162199 (docs(time): clarify exact seconds for hour and minute)
@Zalathar

Zalathar commented Sep 3, 2026

Copy link
Copy Markdown
Member

Possibly failed in rollup in test-various: #162216 (comment)

@bors r-
@bors try jobs=test-various

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2026
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162216), which was unapproved.

View changes since this unapproval

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
sanitizers: Implement support for the sanitize ignorelist


try-job: test-various
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4324521 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

The sanitize ignorelist gives central controls over which functions,
files, etc. should be ignored and not sanitized. It is a common file
format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change
adds support for this list in Rust as well.
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from ae85fdc to c0e55d6 Compare September 3, 2026 15:55
@1c3t3a

1c3t3a commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=test-various

@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@1c3t3a: 🔑 Insufficient privileges: not in try users

@rcvalle

rcvalle commented Sep 3, 2026

Copy link
Copy Markdown
Member

@bors try jobs=test-various

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
sanitizers: Implement support for the sanitize ignorelist


try-job: test-various
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1daec0a (1daec0aa0be8faa472106b7aae6511b95938a499)
Base parent: c33d8f3 (c33d8f3b5a50b56466998e8c5ed8a077d2caed84)

@rcvalle

rcvalle commented Sep 3, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c0e55d6 has been approved by rcvalle

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 4, 2026
…alle

sanitizers: Implement support for the sanitize ignorelist

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 4, 2026
…alle

sanitizers: Implement support for the sanitize ignorelist

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 4, 2026
…alle

sanitizers: Implement support for the sanitize ignorelist

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #157808 (sanitizers: Implement support for the sanitize ignorelist)
 - #160660 (c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`)
 - #162237 (make -Ctarget-feature warnings more explicitly FCWs)
 - #160111 (Generalize Decodable impl for arrays to all types)
 - #162174 (Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`)
 - #162226 (Clean up the AST visitor)
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #157808 (sanitizers: Implement support for the sanitize ignorelist)
 - #160660 (c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`)
 - #162237 (make -Ctarget-feature warnings more explicitly FCWs)
 - #160111 (Generalize Decodable impl for arrays to all types)
 - #162174 (Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`)
 - #162226 (Clean up the AST visitor)
 - #162281 (rustc-dev-guide subtree update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants