Remove the 'sup' method from 'At' and migrate uses to 'sup_raw' by fallible-algebra · Pull Request #164244 · rust-lang/rust

fallible-algebra · 2026-10-13T06:52:24Z

Continuation of #163978

rustbot · 2026-10-13T06:52:28Z

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

rustbot · 2026-10-13T06:52:31Z

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 18 candidates

fallible-algebra · 2026-10-13T06:52:54Z

r? lcnr

lcnr · 2026-10-13T07:43:19Z

        );
        let cause = self.cause(self.self_expr.span, ObligationCauseCode::Misc);
-        match self.at(&cause, self.param_env).sup(DefineOpaqueTypes::Yes, method_self_ty, self_ty) {
+        match self.sup_raw(&cause, self.param_env, DefineOpaqueTypes::Yes, method_self_ty, self_ty)


want to change this to use demand_suptype_diag instead?

View changes since the review

I'm not quite sure how to integrate this here, each way I try to brings up different failures in the test suite (wrt arbitrary self for the most part).

Going to leave this instance of sup_raw here for now.

lcnr · 2026-10-13T07:45:51Z

                                    let target_ty = self.field_ty(base_expr.span, f, args);
                                    let cause = self.misc(base_expr.span);
-                                    match self.at(&cause, self.param_env).sup(
+                                    match self.sup_raw(


this can use self.demand_subtpe_diag and then weaken the diagnostics via https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/diagnostic/struct.Diag.html#method.delay_as_bug

View changes since the review

lcnr

some places which shouldn't be using sup_raw, then r=me

View changes since this review

Co-authored-by: lcnr <rust@lcnr.de>

lcnr · 2026-10-13T08:45:20Z

@rustbot author

fallible-algebra · 2026-10-13T10:48:14Z

@bors r=lcnr

rust-bors · 2026-10-13T10:48:17Z

@fallible-algebra: 🔑 Insufficient privileges: not in review users

fallible-algebra · 2026-10-13T15:22:08Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

lcnr · 2026-10-13T15:27:26Z

@bors r+ rollup

rust-bors · 2026-10-13T15:27:31Z

📌 Commit ae85a2a has been approved by lcnr

It is now in the queue for this repository.

…-sup, r=lcnr Remove the 'sup' method from 'At' and migrate uses to 'sup_raw' Continuation of rust-lang#163978

…uwer Rollup of 12 pull requests Successful merges: - #164040 (move `BoundVarReplacer` into rustc_type_ir) - #162934 (bootstrap: Let test-float-parse follow --target) - #164269 (convert non-generic diagnostic attribute placeholders to snake_case) - #160050 (Fix a splat legacy demangling display bug) - #163383 (Provide context span pointing at trait/item when talking about assoc items) - #164023 (make `with_post_analysis_normalized` invalidate rigid aliases) - #164041 (Add regression test for dead-code with external trait impl) - #164166 (Ignore thread-related tests for UEFI) - #164229 (Update outdated `hir_attrs` doc) - #164244 (Remove the 'sup' method from 'At' and migrate uses to 'sup_raw') - #164257 (Add transmutability test to cover for superseded PR) - #164263 (Fix expected output for x86-64-sysv64-arg-ext.apple.stderr)

Rollup merge of #164244 - fallible-algebra:at-removal/remove-sup, r=lcnr Remove the 'sup' method from 'At' and migrate uses to 'sup_raw' Continuation of #163978

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#164040 (move `BoundVarReplacer` into rustc_type_ir) - rust-lang/rust#162934 (bootstrap: Let test-float-parse follow --target) - rust-lang/rust#164269 (convert non-generic diagnostic attribute placeholders to snake_case) - rust-lang/rust#160050 (Fix a splat legacy demangling display bug) - rust-lang/rust#163383 (Provide context span pointing at trait/item when talking about assoc items) - rust-lang/rust#164023 (make `with_post_analysis_normalized` invalidate rigid aliases) - rust-lang/rust#164041 (Add regression test for dead-code with external trait impl) - rust-lang/rust#164166 (Ignore thread-related tests for UEFI) - rust-lang/rust#164229 (Update outdated `hir_attrs` doc) - rust-lang/rust#164244 (Remove the 'sup' method from 'At' and migrate uses to 'sup_raw') - rust-lang/rust#164257 (Add transmutability test to cover for superseded PR) - rust-lang/rust#164263 (Fix expected output for x86-64-sysv64-arg-ext.apple.stderr)

Remove the 'sup' method from 'At' and migrate to 'sup_raw'

c9aa6d1

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2026

rustbot assigned khyperia Oct 13, 2026

rustbot assigned lcnr and unassigned khyperia Oct 13, 2026

lcnr reviewed Oct 13, 2026

View reviewed changes

Comment thread compiler/rustc_hir_typeck/src/callee.rs

lcnr reviewed Oct 13, 2026

View reviewed changes

Apply suggestion from @lcnr

e1f6010

Co-authored-by: lcnr <rust@lcnr.de>

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2026

Use demand_suptype_diag instead

ae85a2a

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2026

This was referenced Oct 13, 2026

Rollup of 13 pull requests #164276

Closed

Rollup of 12 pull requests #164280

Merged

rust-bors Bot merged commit 9b79cc7 into rust-lang:main Oct 14, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 14, 2026

rust-bors Bot pushed a commit that referenced this pull request Oct 14, 2026

Unrolled build for #164244 in rollup 164280

c710c43

Rollup merge of #164244 - fallible-algebra:at-removal/remove-sup, r=lcnr Remove the 'sup' method from 'At' and migrate uses to 'sup_raw' Continuation of #163978

fallible-algebra mentioned this pull request Oct 14, 2026

Remove the 'sub' method from 'At' and migrate to 'sub_raw' #164303

Open

Conversation

fallible-algebra commented Oct 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 13, 2026

Uh oh!

rustbot commented Oct 13, 2026

Uh oh!

fallible-algebra commented Oct 13, 2026

Uh oh!

lcnr Oct 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fallible-algebra Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

fallible-algebra Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lcnr Oct 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr commented Oct 13, 2026

Uh oh!

fallible-algebra commented Oct 13, 2026

Uh oh!

rust-bors Bot commented Oct 13, 2026

Uh oh!

fallible-algebra commented Oct 13, 2026

Uh oh!

lcnr commented Oct 13, 2026

Uh oh!

rust-bors Bot commented Oct 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fallible-algebra commented Oct 13, 2026 •

edited by rustbot

Loading

lcnr Oct 13, 2026 •

edited by rustbot

Loading

lcnr Oct 13, 2026 •

edited by rustbot

Loading

lcnr left a comment •

edited by rustbot

Loading