improve diagnostic for literals in lint attributes by annieversary · Pull Request #164486 · rust-lang/rust

annieversary · 2026-10-17T19:34:19Z

Improves the diagnostic for literals in lint attributes, like #[allow("meow")].

Before:

error[E0452]: malformed lint attribute input
 --> main.rs:5:9
  |
5 | #[allow("meow")]
  |         ^^^^^^ bad attribute argument

error[E0452]: malformed lint attribute input
 --> main.rs:8:8
  |
8 | #[deny(1.0)]
  |        ^^^ bad attribute argument

After:

error: expected path to a lint, found literal
 --> main.rs:5:9
  |
5 | #[allow("meow")]
  |         ^^^^^^ not a lint
  |
  = help: try using `#[allow(meow)]`

error: expected path to a lint, found literal
 --> main.rs:8:8
  |
8 | #[deny(1.0)]
  |        ^^^ not a lint
  |
  = help: for example, write `#[deny(dead_code)]` for `dead_code`

Probably easier to review with whitespace changes turned off.

r? JonathanBrouwer

rustbot · 2026-10-17T19:34:23Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-10-17T19:34:25Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-10-17T19:34:26Z

Thanks for the pull request, and welcome! The Rust Project has assigned @JonathanBrouwer (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

jdonszelmann

Could you add a test for this change?

View changes since this review

jdonszelmann · 2026-10-17T19:37:32Z

Also grats on your first contrib ^.^

annieversary · 2026-10-17T21:49:28Z

I added a test (as a commit before the one with my change, as suggested by @N1ark), changed the original commit to update this test and another that failed, and made another commit to rename sub to kind. :3

JonathanBrouwer

r=me after that

View changes since this review

rustbot · 2026-10-18T09:04:14Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer

@bors r+ rollup
Thanks a lot for improving this!

View changes since this review

rust-bors · 2026-10-18T14:59:05Z

📌 Commit 31b27ab has been approved by JonathanBrouwer

It is now in the queue for this repository.

…JonathanBrouwer improve diagnostic for literals in lint attributes Improves the diagnostic for literals in lint attributes, like `#[allow("meow")]`. Before: ``` error[E0452]: malformed lint attribute input --> main.rs:5:9 | 5 | #[allow("meow")] | ^^^^^^ bad attribute argument error[E0452]: malformed lint attribute input --> main.rs:8:8 | 8 | #[deny(1.0)] | ^^^ bad attribute argument ``` After: ``` error: expected path to a lint, found literal --> main.rs:5:9 | 5 | #[allow("meow")] | ^^^^^^ not a lint | = help: try using `#[allow(meow)]` error: expected path to a lint, found literal --> main.rs:8:8 | 8 | #[deny(1.0)] | ^^^ not a lint | = help: for example, write `#[deny(dead_code)]` for `dead_code` ``` Probably easier to review with whitespace changes turned off. r? JonathanBrouwer

rust-bors · 2026-10-18T15:01:02Z

This pull request was unapproved due to being closed.

This PR was contained in the following rollups:

Rollup of 7 pull requests #164524 was closed
Rollup of 6 pull requests #164525 was closed

JonathanBrouwer · 2026-10-18T15:01:13Z

Whoops I did not intend on doing that
@bors r+ rollup

rust-bors · 2026-10-18T15:01:16Z

📌 Commit 31b27ab has been tentatively approved by JonathanBrouwer

It will be put into the queue for this repository once PR CI succeeds.

JonathanBrouwer · 2026-10-18T15:01:46Z

@bors r+ force

rust-bors · 2026-10-18T15:01:50Z

📌 Commit 31b27ab has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 6 pull requests Successful merges: - #164518 (stdarch subtree update) - #164497 (Generate redirect pages for hidden modules) - #113891 (Add more syscall doc aliases to std docs) - #163692 (breakpoint: warn against relying on SIGTRAP aborts) - #164486 (improve diagnostic for literals in lint attributes) - #164511 (abort_on_unwind: clarify docs)

Rollup merge of #164486 - annieversary:bad-attribute-lit, r=JonathanBrouwer improve diagnostic for literals in lint attributes Improves the diagnostic for literals in lint attributes, like `#[allow("meow")]`. Before: ``` error[E0452]: malformed lint attribute input --> main.rs:5:9 | 5 | #[allow("meow")] | ^^^^^^ bad attribute argument error[E0452]: malformed lint attribute input --> main.rs:8:8 | 8 | #[deny(1.0)] | ^^^ bad attribute argument ``` After: ``` error: expected path to a lint, found literal --> main.rs:5:9 | 5 | #[allow("meow")] | ^^^^^^ not a lint | = help: try using `#[allow(meow)]` error: expected path to a lint, found literal --> main.rs:8:8 | 8 | #[deny(1.0)] | ^^^ not a lint | = help: for example, write `#[deny(dead_code)]` for `dead_code` ``` Probably easier to review with whitespace changes turned off. r? JonathanBrouwer

…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#164518 (stdarch subtree update) - rust-lang/rust#164497 (Generate redirect pages for hidden modules) - rust-lang/rust#113891 (Add more syscall doc aliases to std docs) - rust-lang/rust#163692 (breakpoint: warn against relying on SIGTRAP aborts) - rust-lang/rust#164486 (improve diagnostic for literals in lint attributes) - rust-lang/rust#164511 (abort_on_unwind: clarify docs)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2026

rustbot assigned JonathanBrouwer Oct 17, 2026

jdonszelmann reviewed Oct 17, 2026

View reviewed changes

Comment thread compiler/rustc_attr_parsing/src/attributes/lint.rs Outdated

This comment has been minimized.

Sign in to view

annieversary added 3 commits October 17, 2026 23:23

add test for literals in lint attributes

c7ea602

improve diagnostic for literals in lint attributes

7142f9a

rename sub to kind in attribute diagnostics

1cb7727

annieversary force-pushed the bad-attribute-lit branch from 1697d6c to 1cb7727 Compare October 17, 2026 21:45

jdonszelmann reviewed Oct 18, 2026

View reviewed changes

Comment thread tests/ui/diagnostic-flags/deduplicate-diagnostics.deduplicate.stderr Outdated

Comment thread tests/ui/diagnostic-flags/deduplicate-diagnostics.rs Outdated

Comment thread tests/ui/lint/lint-attribute-literals.rs Outdated

This comment has been minimized.

Sign in to view

annieversary added 2 commits October 18, 2026 09:13

change label in BadAttributeLit to be more descriptive

4245f27

change t/u/l/lint-attribute-literals to not deduplicate-diagnostics

1c9a4b7

annieversary force-pushed the bad-attribute-lit branch from c733425 to 1c9a4b7 Compare October 18, 2026 07:30

JonathanBrouwer requested changes Oct 18, 2026

View reviewed changes

Comment thread compiler/rustc_attr_parsing/src/diagnostics.rs Outdated

Comment thread compiler/rustc_attr_parsing/src/diagnostics.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2026

annieversary added 2 commits October 18, 2026 15:13

simplify BadAttributeLit diagnostic message

f9d044c

add test for the BadAttributeLitHelp::Other case

31b27ab

JonathanBrouwer approved these changes Oct 18, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2026

This was referenced Oct 18, 2026

Rollup of 7 pull requests #164524

Closed

Rollup of 6 pull requests #164525

Merged

JonathanBrouwer closed this Oct 18, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2026

JonathanBrouwer reopened this Oct 18, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2026

rust-bors Bot merged commit 62d48ad into rust-lang:main Oct 18, 2026
28 checks passed

rustbot added this to the 1.101.0 milestone Oct 18, 2026

annieversary deleted the bad-attribute-lit branch October 18, 2026 19:41

Conversation

annieversary commented Oct 17, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 17, 2026

Uh oh!

rustbot commented Oct 17, 2026

Uh oh!

rustbot commented Oct 17, 2026

Uh oh!

jdonszelmann left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jdonszelmann commented Oct 17, 2026

Uh oh!

This comment has been minimized.

annieversary commented Oct 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rustbot commented Oct 18, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 18, 2026

Uh oh!

rust-bors Bot commented Oct 18, 2026

Uh oh!

JonathanBrouwer commented Oct 18, 2026

Uh oh!

rust-bors Bot commented Oct 18, 2026

Uh oh!

JonathanBrouwer commented Oct 18, 2026

Uh oh!

rust-bors Bot commented Oct 18, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

annieversary commented Oct 17, 2026 •

edited by rustbot

Loading

jdonszelmann left a comment •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading