Repository navigation
Rollup of 7 pull requests - #164524
Closed
JonathanBrouwer wants to merge 47 commits into
Closed
Rollup of 7 pull requests#164524JonathanBrouwer wants to merge 47 commits into
JonathanBrouwer wants to merge 47 commits into
Conversation
…i16 and _mm256_mulhi_epu16 without LLVM intrinsics" This reverts commit 7abc64d599fcc93719f17ee08a03390d81424800.
Miri reports UB on division by zero with the LSX vdiv/vmod intrinsics when implemented via the portable simd_div/simd_rem helpers. [^1] Per clarification from the LoongArch ISA developers, the hardware defines that vdiv/vmod return 0 when the divisor is zero (this will be documented in the SIMD reference). This differs from the earlier assumption in PR rust-lang#2078, so the portable helpers are not a correct match. Switch back to the corresponding LLVM intrinsics so the Rust wrappers preserve the defined ISA behavior. [^1]: rust-lang/stdarch#2221 (comment)
Revert "Reimplement _mm_mulhi_epi16, ... without LLVM intrinsics"
…_mm256_avg_epu16 without LLVM intrinsics" This reverts commit 87e6703ba1a2c44d27f9e4f55dfcf145bca2834a.
This updates the rust-version file to 21b707e.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 21b707e Filtered ref: 409f94218f084bd1a9d20abe1c2be1562d726672 Upstream diff: rust-lang/rust@220b36c...21b707e This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
Add libs-nominated triagebot config
The add expectation reads add.rn.f16x22, which is no PTX instruction. LLVM's own NVPTX codegen test, llvm/test/CodeGen/NVPTX/f16x2-instructions.ll, expects add.rn.f16x2 for fadd <2 x half>, and the sub, mul, fma and neg expectations in this file already match what it emits. Nothing caught the typo because assert_instr never runs on nvptx: CI builds that target with NORUN=1 and NOSTD=1. The neg docs name __hmin2 and the fma docs name __fma2 and __fma2_rn. cuda_fp16.h (CUDA 12.4) declares __hneg2 and __hfma2, and none of the other three names exist; the fma link already resolved to __hfma2.
loongarch: Use LLVM intrinsics for vdiv/vmod
…ations Fix the nvptx f16x2 intrinsic annotations
This updates the rust-version file to 260f1ac.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@21b707e New upstream ref: rust-lang/rust@260f1ac Filtered ref: rust-lang/stdarch@97f8f7e Upstream diff: rust-lang/rust@21b707e...260f1ac This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
See: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/josh-sync.20pull.20workflow.20version.20pinning/near/629742031 Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/actions/checkout/releases/tag/v6.1.0 This is the same version we were already using as of writing this. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Revert "Reimplement _mm_avg_epu8, _mm_avg_epu16, _mm256_avg_epu8 and _mm256_avg_epu16 without LLVM intrinsics"
Remove myself from the review rotation
…atch_and_stale-action-refs_and_unpinned-uses ci: Resolve `ref-version-mismatch`, `stale-action-refs`, and `unpinned-uses`
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
… it is always in the code
This fixes an intra-doc link, shown in the test case, where the private path gets used as the link target.
…, r=folkertdev stdarch subtree update Subtree update of `stdarch` to rust-lang/stdarch@eb9b302. Created using https://github.com/rust-lang/josh-sync. r? @ghost
…uillaumeGomez Generate redirect pages for hidden modules This fixes an intra-doc link, shown in the test case, where the private path gets used as the link target. Bug was reported [on the unofficial Discord](https://discord.com/channels/273534239310479360/273541522815713281/1561027634681348187).
…, r=clarfonthey Add more syscall doc aliases to std docs Some of these are quite trivial but we should optimize for the user not having to think about it. Blocked on rust-lang/std-dev-guide#64
…fonthey breakpoint: warn against relying on SIGTRAP aborts This is mostly based on https://issues.chromium.org/issues/40625592 where Chromium devs report > Note: on Intel, the debugger breakpoint instruction (int3) is only one byte, while the fatal termination instruction (ud2) is two bytes. Unfortunately, crash reports seem to be indicating that int3 is non-fatal. Since it's important that TRAP_SEQUENCE() terminates, it cannot rely on int3. FWIW they seem to also be worried about debugger users > Make sure it crashes in case a developer steps past the breakpoint That was 7 years ago, so maybe there's an update we could get somehow -- does anyone have contacts with the Chrome team at Google? That said, looking at the code, they [still have the extra ud2 today](https://github.com/v8/v8/blob/5fe0aa3bc79c0a9d3ad546b79211f07105f09585/src/base/immediate-crash.h#L58). The code also has a comment saying ``` // TODO(https://crbug.com/958675): In theory, it should be possible to use just // int3. However, there are a number of crashes with SIGILL as the exception // code, so it seems likely that there's a signal handler that allows execution // to continue after SIGTRAP. ``` That link goes to the above bug. The code also has indications of an unfinished transition ``` // [...] In addition, the int3/bkpt/brk will // be removed in followups, so splitting it up like this now makes it easy to // land the followups. ``` That comment was written at least 5 years ago though. r? @tgross35 Cc @joshtriplett
…r=lolbinarycat [rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc The 3 first commits come from rust-lang#164266. While working on it, I realized that even though we added a condition for the sidebar heading, we always have: <img width="520" height="146" alt="image" src="https://github.com/user-attachments/assets/94a7c109-6cc0-4a37-831b-7e40a06f44a4" /> So there should be a heading to reflect it. r? @Urgau
…JonathanBrouwer
improve diagnostic for literals in lint attributes
Improves the diagnostic for literals in lint attributes, like `#[allow("meow")]`.
Before:
```
error[E0452]: malformed lint attribute input
--> main.rs:5:9
|
5 | #[allow("meow")]
| ^^^^^^ bad attribute argument
error[E0452]: malformed lint attribute input
--> main.rs:8:8
|
8 | #[deny(1.0)]
| ^^^ bad attribute argument
```
After:
```
error: expected path to a lint, found literal
--> main.rs:5:9
|
5 | #[allow("meow")]
| ^^^^^^ not a lint
|
= help: try using `#[allow(meow)]`
error: expected path to a lint, found literal
--> main.rs:8:8
|
8 | #[deny(1.0)]
| ^^^ not a lint
|
= help: for example, write `#[deny(dead_code)]` for `dead_code`
```
Probably easier to review with whitespace changes turned off.
r? JonathanBrouwer
…kruppe abort_on_unwind: clarify docs Tracking issue: rust-lang#130338
rustbot
added
A-attributes
Contributor
|
PR #164486, which is a member of this rollup, was closed. This rollup was closed. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Warning
This rollup conflicts with pending auto build #164517 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup