Skip to content

Revert "Remove indirection for Expr in Body" - #164581

Open
JonathanBrouwer wants to merge 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-indirect
Open

Revert "Remove indirection for Expr in Body"#164581
JonathanBrouwer wants to merge 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-indirect

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This reverts #164047

Not a clean revert, but only trivial changes needed.
Reverted because there was no perf gain, it broke the input-stats test, and another approach discussed in the original PR is preferable

r? nnethercote

@JonathanBrouwer
Revert "Remove indirection for Expr in Body"
ba9d806 
This reverts commit 8499655, reversing
changes made to f3983ba.
@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in coverage instrumentation.

cc @Zalathar

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 19, 2026
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@bors r=kivooeo rollup
(I'm assuming this is ok with you based on the approval)

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ba9d806 has been tentatively approved by kivooeo

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@Kivooeo

Kivooeo commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

i checked the diff and it looks fine (i forget to write comment with approval, 2am brain moment)

but i didn’t merge it since it’s 1am for Nick and he’s probably asleep

so let’s wait for him to merge it so everyone is happy

@bors r- for now

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2026
@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@JonathanBrouwer

JonathanBrouwer commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Nick is in the Netherlands right now and I spoke to him about the change quickly, he agrees with the change I think. Happy to wait for him to review tho

@Kivooeo

Kivooeo commented Oct 19, 2026

Copy link
Copy Markdown
Member

ah, he moved to Netherlands, in that case it’s ok, i’m confident in the diff so let’s move on it

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ba9d806 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2026
tgross35 added a commit to tgross35/rust that referenced this pull request Oct 20, 2026
@tgross35
Rollup merge of rust-lang#164581 - JonathanBrouwer:revert-indirect, r…
1eb05e7 
…=Kivooeo

Revert "Remove indirection for `Expr` in `Body`"

This reverts rust-lang#164047

Not a clean revert, but only trivial changes needed.
Reverted because there was no perf gain, it broke the input-stats test, and another approach discussed in the original PR is preferable

r? nnethercote
@tgross35 tgross35 mentioned this pull request Oct 20, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Oct 20, 2026
@bors
Auto merge of #164609 - tgross35:rollup-oDWHXH1, r=tgross35
39b126b 
Rollup of 5 pull requests

Successful merges:

 - #164568 (Exclude MaybeDangling like types from SROA)
 - #163771 (update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries)
 - #164268 ([rustdoc]  Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc)
 - #164581 (Revert "Remove indirection for `Expr` in `Body`")
 - #164606 (triagebot: Delete the libs ad-hoc group)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @Kivooeo @nnethercote