This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
Conversation
Deco354
added a commit
to sentfutures/devops
that referenced
this pull request
Oct 9, 2026
…ockfiles Under this PR a generated_paths file gets no diff, so the review cannot see it at all; before, its hunks were in the diff it was told to skim. A lockfile's changes are small (factory-farm-em's uv.lock: 2-56 lines) and are the only place indirect dependency and source changes show, so the input description, README and caller template stop suggesting uv.lock, and the template's 'skim' comment is corrected. Mirrored in sentfutures/.github#4; factory-farm-em#44 stops withholding its uv.lock.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Written by Claude Code at @Deco354's direction.
What changes
This updates the
generated_pathscomment inworkflow-templates/claude-pr-review.yml. It mirrors the edit tocallers/claude-pr-review.caller.ymlin sentfutures/devops#12.Under devops#12, a
generated_pathsfile gets no diff: the review sees only its name and size. Before, its changes were part of the diff the review was told to skim. A lockfile's changes are small and are the only place indirect dependency and source changes show, so the template no longer invites withholding one.Merge after devops#12, which changes what the input does.
This is independent of #3, which is the companion to devops#9 and has been open since 2026-09-30. The two PRs touch different lines and merge cleanly in either order. With both merged, this template is identical to the devops caller template again (checked byte for byte).
How to test
diff <(gh api -H "Accept: application/vnd.github.raw" repos/sentfutures/.github/contents/workflow-templates/claude-pr-review.yml) <(gh api -H "Accept: application/vnd.github.raw" repos/sentfutures/devops/contents/callers/claude-pr-review.caller.yml).