Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ Nothing runs locally. Changes are tested and released by the PR flow itself:
event. Rollback is re-pointing the tag:
`git push origin +<old-sha>:refs/tags/v1`.
- **Breaking changes** (renamed/removed input) must not ride `v1`: tag `v2`,
update `callers/` and the `sentfutures/.github` templates to `@v2`, add a
README changelog entry.
update `callers/` to `@v2`, add a README changelog entry.

To exercise the plugin skills locally:
`/plugin marketplace add sentfutures/devops` then
Expand Down Expand Up @@ -142,8 +141,11 @@ reintroduce.

## Files that move together

- `callers/*.caller.yml` are **mirrored** as org workflow templates in
`sentfutures/.github/workflow-templates/` — update both.
- `callers/*.caller.yml` are the only copy of the callers. The org workflow
templates that mirrored them in `sentfutures/.github` were retired on
2026-10-09 (sentfutures/.github#5): no repo had been installed from them,
repos under personal accounts can't see org templates, and the copy
drifted. Don't re-add them without a sync check.
- `skills/pr-review-watch/SKILL.md` is the **canonical** copy; consuming
repos hold copies under `.claude/skills/`. Improve it here, and keep the
"In this repo (fill in at install…)" section as a fill-in template.
Expand Down
22 changes: 13 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@ person opens a PR.
1. **Label** — create `needs-human-review` in the repo (Issues → Labels). A
missing label only degrades to a warning in the run log, so do it up
front where it's visible.
2. **Workflows** — repo → Actions → New workflow → under **"By sentfutures"**
choose **"Claude PR review bot — reviews every PR"** → Configure → replace
the two `FILL_ME_IN` values (`required_check`: your CI check's name as it
appears on a PR, or delete the line if there is none; `escalate_to`:
maintainer GitHub logins) → commit. Repeat for **"Claude @mention handler
— on-demand"** (nothing to fill in). Equivalent: copy both files from this
repo's `callers/` into your `.github/workflows/`.
2. **Workflows** — copy `callers/claude-pr-review.caller.yml` and
`callers/claude-mention.caller.yml` from this repo into your
`.github/workflows/` as `claude-pr-review.yml` and `claude-mention.yml`.
In the review caller, replace the two `FILL_ME_IN` values:
- `required_check`: your CI check's name as it appears on a PR, or delete
the line if there is none.
- `escalate_to`: maintainer GitHub logins.

The mention caller has nothing to fill in. Commit both. (Until 2026-10-09
these were also offered as org workflow templates in `sentfutures/.github`.
They were retired: no repo had been set up from them, repos under personal
accounts can't see org templates, and the second copy kept drifting.)
3. **Skill** — copy `skills/pr-review-watch/` from this repo into your repo's
`.claude/skills/` and complete its "In this repo" fill-in bullets from
your repo's own CLAUDE.md and CI. That skill is how a Claude Code session
Expand Down Expand Up @@ -227,8 +232,7 @@ Three tiers, in order of how often they should happen:
Code: *"in sentfutures/devops, add <X> to the review bot's prompt and open
a PR"*.
3. **Breaking changes** (rename/remove an input): do not ride `v1`. Tag `v2`,
update `callers/` and the `sentfutures/.github` templates to `@v2`, and
add a changelog entry below.
update `callers/` to `@v2`, and add a changelog entry below.
4. **Never** edit the verdict-verification step's jq or the tool allowlist
without reading their inline comments first — each line exists because of
a production incident, and the selftest may not catch the failure mode you
Expand Down
3 changes: 0 additions & 3 deletions callers/claude-mention.caller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ name: Claude mention handler
#
# NOTE the permissions: this handler gets contents: write (it can push
# commits when asked to) — a deliberately broader grant than the review bot's.
#
# This file is mirrored as an org workflow template in sentfutures/.github —
# keep the two in sync when editing.
on:
issue_comment:
types: [created]
Expand Down
3 changes: 0 additions & 3 deletions callers/claude-pr-review.caller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ name: Claude PR review bot
# (.github/workflows/claude-pr-review.yml); this file only carries the
# triggers and this repo's own settings. Setup steps (app install, secret
# access, label, branch protection): see the sentfutures/devops README.
#
# This file is mirrored as an org workflow template in sentfutures/.github —
# keep the two in sync when editing.
on:
pull_request:
# `edited` re-reviews when a stacked PR retargets its base branch (GitHub
Expand Down
Loading