Repository navigation
Conversation
t20100
reviewed
Oct 23, 2026
t20100
left a comment
t20100
left a comment
Member
There was a problem hiding this comment.
Quick review:
This sounds a lot of logic to support hot change of the profiling.
Also it looks one has to know the internal logic to know which parameters will be used or not. It would be good to either simplify this or warn when an argument is set and not used.
I leave the second look to @pierrepaleo
| normalize=normalize, | ||
| ) | ||
| self.ctx = ctx | ||
| self.queue = queue |
Member
There was a problem hiding this comment.
raise ValueError or at least log a warning if both ctx and queue are provided
| deviceid=None, | ||
| memory=None, | ||
| profile=False, | ||
| queue=None, |
| np.int32(src_offset), | ||
| np.int32(transfer_shape[::-1]), | ||
| ) | ||
| ev.wait() |
Member
There was a problem hiding this comment.
behavior change: this is not longer guaranteed to be done.
maybe it's the same at other places, to be checked.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
The idea behind this PR is to share a single instance of OpenclQueue which carries the context, the queue, the device and the profiling configuration state.
Code in the different stages of silx has been addressed and remains backwards compatible.
Close #4755
AI Disclosure