You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix the arm64 release build and a racy routing test - #333
Fixes the two failures from e3b4c47d, so a new beta can publish.
Linux arm64 release build
The v3.2.0-beta.2 run failed on ubuntu-22.04-arm with Could not create task ':core:kspKotlinIosArm64' / Unknown host target: linux aarch64, so nothing published. The other four desktop targets built, including their --version checks.
The cause is in Nucleus, fixed by NucleusFramework/Nucleus#904. Until that ships, the release build passes -PiosSkip=true, as CI and the Android job already do. Desktop packaging doesn't use the iOS targets.
Racy routing test
aPushToADeclaredStreamGoesThere failed on main at WraythStreamRoutingTests.kt:87. The harness cancelled its collectors as soon as the client disconnected, while they could still be draining buffered lines on other threads. The test code itself was the problem, not the client. The collectors now run on Dispatchers.Unconfined, so each takes a line inside the client's own send and nothing is buffered at disconnect.
Tested
WraythStreamRoutingTests passes 20 reruns with every core under load. The original failure never reproduced here, so that doesn't prove the race is gone.
:desktopApp:packageGraalvmDeb and :desktopApp:packageGraalvmAppImage with -PiosSkip=true build on Linux x64. The packaged binary reports its version with exit code 0 and replayed a game log for 25 seconds.
Not tested: the arm64 build itself, which only a release run exercises, or iosSkip builds on Windows and macOS.
Desktop release builds now explicitly skip iOS-specific tasks.
Tests
Stream-routing checks now wait for stream events to be collected after disconnecting, making the checks more reliable when event delivery takes time. The existing timeout continues to limit how long the checks can wait.
v3.2.0-beta.2 failed on Linux arm64: Nucleus's native-image resource task creates the
iOS tasks of the app's modules, and the Kotlin plugin refuses to create those there.
Pass iosSkip, as CI and the Android job already do. NucleusFramework/Nucleus#904 fixes
the cause.
WraythStreamRoutingTests cancelled its collectors as soon as the client disconnected,
which could drop lines they hadn't reached yet and failed CI on main. Wait for them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release workflow passes -PiosSkip=true to desktop Gradle builds. The stream routing test helper waits for collectors to receive expected events and for the main event count to remain unchanged before it returns.
Changes: Release workflow
Layer / File(s)
Summary
Set release Gradle property .github/workflows/release.yaml
The desktop release Gradle invocation now passes -PiosSkip=true for all matrix runners.
Stream routing test waits
Layer / File(s)
Summary
Wait for stream collectors to drain wrayth/src/jvmTest/kotlin/WraythStreamRoutingTests.kt
After disconnecting, the helper waits until collectors receive at least feed.linesSent events. It then waits for the main event count to remain unchanged across a 50 ms interval. Both waits remain within the existing 10-second timeout.
The routing test can remain intermittently flaky; add an explicit eventFlow completion barrier before merging.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely identifies both main changes: the arm64 release build fix and the racy routing test fix.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Waiting for main to go quiet for 50 ms still loses events if the collector stalls for
longer. Unconfined collectors take each line inside the client's send, so nothing is
buffered at disconnect and the test needs no wait at all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Fixes the two failures from
e3b4c47d, so a new beta can publish.Linux arm64 release build
The v3.2.0-beta.2 run failed on
ubuntu-22.04-armwithCould not create task ':core:kspKotlinIosArm64'/Unknown host target: linux aarch64, so nothing published. The other four desktop targets built, including their--versionchecks.The cause is in Nucleus, fixed by NucleusFramework/Nucleus#904. Until that ships, the release build passes
-PiosSkip=true, as CI and the Android job already do. Desktop packaging doesn't use the iOS targets.Racy routing test
aPushToADeclaredStreamGoesTherefailed on main atWraythStreamRoutingTests.kt:87. The harness cancelled its collectors as soon as the client disconnected, while they could still be draining buffered lines on other threads. The test code itself was the problem, not the client. The collectors now run onDispatchers.Unconfined, so each takes a line inside the client's own send and nothing is buffered at disconnect.Tested
WraythStreamRoutingTestspasses 20 reruns with every core under load. The original failure never reproduced here, so that doesn't prove the race is gone.:desktopApp:packageGraalvmDeband:desktopApp:packageGraalvmAppImagewith-PiosSkip=truebuild on Linux x64. The packaged binary reports its version with exit code 0 and replayed a game log for 25 seconds.Not tested: the arm64 build itself, which only a release run exercises, or
iosSkipbuilds on Windows and macOS.🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Tests