Skip to content

Fix the arm64 release build and a racy routing test #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sproctor merged 2 commits into from
Nov 3, 2026
Merged

Fix the arm64 release build and a racy routing test #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5efadab
Fix the arm64 release build and a racy routing test
sproctor Nov 3, 2026
f22415b
Collect routing test events on the client's own thread
sproctor Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ jobs:
fi
log="$(mktemp)"
status=0
./gradlew $TASKS --stacktrace --no-daemon 2>&1 | tee "$log" \
# iosSkip: Nucleus's native-image resource task pulls in the iOS tasks of the app's modules,
# and the Kotlin plugin refuses to create those on a Linux arm64 host.
./gradlew $TASKS -PiosSkip=true --stacktrace --no-daemon 2>&1 | tee "$log" \
|| status="${PIPESTATUS[0]}"
if [ "$status" -eq 0 ]; then
exit 0
Expand Down
6 changes: 4 additions & 2 deletions wrayth/src/jvmTest/kotlin/WraythStreamRoutingTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ class WraythStreamRoutingTests {
val main = mutableListOf<ClientTextEvent>()
val streams = mutableListOf<ClientTextEvent>()
val mainSubscribed = CompletableDeferred<Unit>()
scope.launch {
// Unconfined, so each collector takes a line inside the client's own send: nothing can
// still be buffered when the client disconnects, and scope.cancel below loses nothing.
scope.launch(Dispatchers.Unconfined) {
client.eventFlow.onSubscription { mainSubscribed.complete(Unit) }.collect { event ->
if (event is ClientTextEvent) {
synchronized(main) { main += event }
Expand All @@ -168,7 +170,7 @@ class WraythStreamRoutingTests {
}
// Undispatched, so each is subscribed before the client connects.
for (stream in watched) {
scope.launch(start = CoroutineStart.UNDISPATCHED) {
scope.launch(Dispatchers.Unconfined, start = CoroutineStart.UNDISPATCHED) {
client.streamLines(stream).collect { event ->
synchronized(streams) { streams += event }
}
Expand Down
Loading