Repository navigation
test(appproto): check support audit without row order - #1655
Merged
Merged
Conversation
frahlg
added
the
no-changeset
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
force-pushed
the
fix/support-audit-test-order
branch
2 times, most recently
from
October 16, 2026 04:41
22fc595 to
ade5cbb
Compare
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
force-pushed
the
fix/support-audit-test-order
branch
from
October 16, 2026 04:43
ade5cbb to
658b65d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support-grant test sometimes fails because it treats the last flushed audit row as the accepted staff call. The minute's rows come from a Go map and have no defined order.
Find the accepted call by its result, then check its staff identity, principal, actor and count. Fail if the accepted call is missing. This changes only the test.
Validation: the original test failed twice in 20 runs during full release checks. The corrected test passes 100 runs; the full appproto package passes with the race detector. No changeset is needed for this test-only fix.