Skip to content

test(appproto): check support audit without row order #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frahlg merged 1 commit into from
Oct 16, 2026
Merged

test(appproto): check support audit without row order #1655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions go/internal/appproto/agents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,8 +621,20 @@ func TestASupportGrantEndsWhenItsTicketCloses(t *testing.T) {
}
r.agents.FlushAudit(r.audit, r.clock.now.Add(time.Minute).UnixMilli())
rows := r.audit.find(protocol.MsgHealthGet)
if last := rows[len(rows)-1]; last.By != "staff:s7" || last.Principal != "FTW-123" || last.Actor != "agent:"+row.ID {
t.Errorf("audit %+v", last)
// Folded reads have no order within a minute. Check the accepted call,
// which may precede the rejected calls in the flushed rows.
found := false
for _, entry := range rows {
if entry.Result != "ok" {
continue
}
found = true
if entry.By != "staff:s7" || entry.Principal != "FTW-123" || entry.Actor != "agent:"+row.ID || entry.Count != 1 {
t.Errorf("audit %+v", entry)
}
}
if !found {
t.Errorf("accepted support call absent from audit: %+v", rows)
}

// Another agent's row is not its to revoke.
Expand Down
Loading