Skip to content

feat(install): share skill sources across local agents - #5

Closed
sungyongcho wants to merge 2 commits into
mainfrom
codex/3-shared-installation
Closed

sungyongcho wants to merge 2 commits into
mainfrom
codex/3-shared-installation

Conversation

@sungyongcho

@sungyongcho sungyongcho commented Sep 7, 2026 •

Copy link
Copy Markdown
Collaborator
  • Work status: REVIEW_READY
  • Worker: 01a07ca1-b13b-7e52-89af-30369e17ee08
  • Assignment: shared-installation
  • Scope: Deliver issue 3 shared source installer, release maintenance and provider setup
  • PR: feat(install): share skill sources across local agents #5
  • Verification: passed: 16 local tests, Linux and macOS CI, release metadata, shell syntax and source discovery; external Claude OAuth and missing Gemini CLI remain documented
  • Updated: 2026-09-07 17:42:20 UTC
  • Head: 8807100

Codex, Claude Code and Gemini now use one local Commit It source with provider discovery links. The standalone installer preserves existing work, requires explicit updates and ships copyable per-agent setup instructions. Release numbering is decided at release time; the inherited 2.9.0 version and merged conflict-resolution policy are preserved.

Validation: 16 package tests, release metadata, shell syntax and diff checks passed. Codex discovery and invocation passed. Claude discovery passed, but invocation is blocked by the existing expired OAuth session; Gemini CLI is not installed.

Closes #3

Summary
Install one shared Commit It source for Codex, Claude Code and Gemini.

Changes
- Add guarded installation, explicit updates and provider discovery links.
- Document per-agent setup and release-time version selection.
- Preserve the merged conflict-resolution policy and upstream version 2.9.0.

Verification
- 16 package tests passed; release metadata and shell syntax checks passed.
- Codex discovery and invocation passed; Claude discovery passed.
- Claude invocation blocked by expired OAuth; Gemini CLI unavailable.

Refs: #3
@sungyongcho-ops sungyongcho-ops added DEV Product features, fixes and product documentation. OCCUPIED An assigned worker owns this work, including waiting or blocked verification. labels Sep 7, 2026
Summary
Verify physical source identity without assuming macOS temporary paths are canonical.

Changes
- Compare linked installation targets using samefile instead of raw path spelling.

Verification
- 16 local package tests passed; diff check passed.
- The original macOS CI failure showed /var resolving to /private/var.
- Cross-platform CI will verify this correction on the pushed commit.

Refs: #3
@sungyongcho-ops sungyongcho-ops added REVIEW_READY Implementation and required verification are complete for the recorded head. and removed OCCUPIED An assigned worker owns this work, including waiting or blocked verification. labels Sep 7, 2026
@sungyongcho-ops
sungyongcho-ops marked this pull request as ready for review September 7, 2026 17:42

@sungyongcho-ops sungyongcho-ops left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: LGTM

Worker: 01a07ca1-b13b-7e52-89af-30369e17ee08
Reviewed head: 880710098336ab2e8bfdc82d06126474ab89fefe.

Reviewed the exact installer and documentation delta. The macOS alias correction preserves physical file identity checks. Linux and macOS CI passed for this head; the inherited conflict-resolution policy and release version remain intact. Runtime authentication limitations are documented.

@sungyongcho-ops

Copy link
Copy Markdown
Owner

Superseded by merged PR #4 at 13274c5. That release incorporates this installation work and adds stronger source, inventory and recovery checks. Its macOS fixtures also canonicalize the temporary directory, covering the path-alias correction from this branch. No unique implementation remains to merge from this PR; preserve the newer published source.

@sungyongcho sungyongcho closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV Product features, fixes and product documentation. REVIEW_READY Implementation and required verification are complete for the recorded head.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(install): preserve shared skill source and release maintenance

2 participants