[ezequielzacca]

This step's own changes: compare with #827. The diff of this PR also holds every earlier step of #815, since a PR from a fork can only target this repository's branches.

Summary

A translation fix in the item tooltips, found in #827. Stacked on #827 (→ #825 → … → #813): only its own commits, fix(items): damage texts without a stray "of", and the Fruits' stat words and fix(items): the Siege Potion's damage line without a stray "i"; …, are this PR. English is unchanged. Since #827, each of these texts lives in one place.

"Increase/Absorb …% of Damage"

The wings', capes' and pets' damage lines kept the English "of" in seven languages:

	Before	After
es	Aumenta el daño de 12% of	Aumenta el daño un 12%
es	Absorber daño 12% of	Absorbe el 12% del daño
pt	Aumentar o dano de 12% of	Aumenta o dano em 12%
ru	Увеличение урона 12% of	Увеличение урона на 12%
ru	Поглощение 12% of урона	Поглощение 12% урона
uk	Збільшення шкоди на 12% of	Збільшення шкоди на 12%
id	Meningkatkan Kerusakan 12% of	Meningkatkan Kerusakan 12%
tl	Dagdagan ang 12% of Pinsala	Dagdagan ang Pinsala nang 12%
zh-TW	增加 12% of 傷害	增加 12% 傷害

That fixes the two shared texts of #827. The Guardian Angel's, Imp's and Horn of Dinorant's lines say the same with a fixed number, and get the same wording. That includes the Imp's "Increase 30% of attacking & Wizardry Dmg", whose Portuguese ended in "de % of".

The Fruits' stat words

The {stat} values of #827 came from a machine translation that went wrong in three ways:

	ENG	STA	AGI	STR	Command
es	ESP ENE	STA VIT	AGI	FUE	Dominio
pt	POR ENE	STA VIT	AGI	FOR	Comando
id	Bahasa Inggris ENG	STA	AGI	STR	Memerintah Kepemimpinan
ru	АНГЛ ЭНЕ	СТА ВЫН	ОИИ ЛВК	СТР СИЛ	Команда Командование
uk	ENG ЕНЕ	STA ВИТ	AGI СПР	ВУЛ СИЛ	Команда Командування
zh-TW	英語 能量	史塔 體力	通用人工智慧 敏捷	STR 力量	命令 統率
pl	ENG	STA	AGI	STR	Rozkaz Dowodzenie
tl	ENG	STA	AGI	STR	Utos Pamumuno

• ENG was read as "English": "ESP" (Spanish), "POR" (Portuguese), "Bahasa Inggris", "АНГЛ" and "英語" (each "English").
• AGI was read as "artificial general intelligence": "ОИИ", "通用人工智慧".
• Command was read as an order: "Rozkaz", "Utos", "Memerintah", "Команда", "命令".

German and Japanese were right.

The Siege Potion's damage line

The "i" of the old %% text's "increase" leaked into seven translations of "Damage +20% increase effect" (found in #819's review). It's gone now:

	Before	After
es	Daño +20% iefecto de aumento	Daño +20% efecto de aumento
id	Kerusakan +20% imeningkatkan efek	Kerusakan +20% meningkatkan efek
pt	Dano +20% infeito de aumento	Dano +20% efeito de aumento
ru	Урон +20% inувеличение эффекта	Урон +20% увеличение эффекта
tl	Pinsala +20% ipagtaas na epekto	Pinsala +20% pagtaas na epekto
uk	Пошкодження +20% inпосилення ефекту	Пошкодження +20% посилення ефекту
zh-TW	傷害+20% i效果增加	傷害+20% 效果增加

#819's test of the level lines compares them with the game's texts in every language; from here it leaves out the Fruits' stat words, which this step corrects while the game's texts keep the old ones (other code prints them).

Not changed

Polish and Tagalog name a few items in English inside a sentence: the "Talisman of Wings of …" texts, "Scroll of Guardian", "Cloak of Invisibility". Those items have no Polish or Tagalog name, so the game shows their names in English there anyway. The texts match that.

The Chinese Fruits shot shows the item name "命令 Fruits". That name comes from the item name code, which step 5d moves. It's fixed there.

Verified

• All 1007 tests pass. The recorded tooltip test is unchanged, since it records English.
• The game's tooltip-snapshot in Russian differs from feat(items): the descriptions' repeated texts are written once #827's in exactly 28 items: the wings and capes, Cape of Lord, Guardian Angel, Imp, Horn of Dinorant and the Fruits.

Screenshots

Wing of Storm +15, Russian

	Legacy theme	Modern theme
Before
After

Command Fruits +4, Russian and Chinese

	Legacy theme, Russian	Modern theme, Russian	Modern theme, Chinese
Before
After

The data (the two shared texts and the Fruits' levelValues, after)

{
  "damageIncrease": {
    "en": "Increase {percent}% of Damage",
    "de": "Erhöht den Schaden um {percent}%",
    "es": "Aumenta el daño un {percent}%",
    "id": "Meningkatkan Kerusakan {percent}%",
    "ja": "ダメージ {percent}%増加",
    "pl": "Zwiększa obrażenia o {percent}%",
    "pt": "Aumenta o dano em {percent}%",
    "ru": "Увеличение урона на {percent}%",
    "tl": "Dagdagan ang Pinsala nang {percent}%",
    "uk": "Збільшення шкоди на {percent}%",
    "zh-TW": "增加 {percent}% 傷害"
  },
  "damageAbsorb": {
    "en": "Absorb {percent}% of Damage",
    "de": "Absorbiert {percent}% des Schadens",
    "es": "Absorbe el {percent}% del daño",
    "id": "Menyerap {percent}% Kerusakan",
    "ja": "ダメージ {percent}%吸収",
    "pl": "Pochłania {percent}% obrażeń",
    "pt": "Absorve {percent}% do dano",
    "ru": "Поглощение {percent}% урона",
    "tl": "Isipsip ang {percent}% ng Pinsala",
    "uk": "Поглинання {percent}% шкоди",
    "zh-TW": "吸收{percent}%傷害"
  }
}
{
  "levelValues": {
    "stat": [
      {
        "en": "ENG",
        "de": "ENG",
        "es": "ENE",
        "id": "ENG",
        "ja": "エナジー",
        "pl": "ENG",
        "pt": "ENE",
        "ru": "ЭНЕ",
        "tl": "ENG",
        "uk": "ЕНЕ",
        "zh-TW": "能量"
      },
      {
        "en": "STA",
        "de": "VIT",
        "es": "VIT",
        "id": "STA",
        "ja": "体力",
        "pl": "STA",
        "pt": "VIT",
        "ru": "ВЫН",
        "tl": "STA",
        "uk": "ВИТ",
        "zh-TW": "體力"
      },
      {
        "en": "AGI",
        "de": "BEW",
        "es": "AGI",
        "id": "AGI",
        "ja": "敏捷性",
        "pl": "AGI",
        "pt": "AGI",
        "ru": "ЛВК",
        "tl": "AGI",
        "uk": "СПР",
        "zh-TW": "敏捷"
      },
      {
        "en": "STR",
        "de": "STÄ",
        "es": "FUE",
        "id": "STR",
        "ja": "力",
        "pl": "STR",
        "pt": "FOR",
        "ru": "СИЛ",
        "tl": "STR",
        "uk": "СИЛ",
        "zh-TW": "力量"
      },
      {
        "en": "Command",
        "de": "Führung",
        "es": "Dominio",
        "id": "Kepemimpinan",
        "ja": "統率",
        "pl": "Dowodzenie",
        "pt": "Comando",
        "ru": "Командование",
        "tl": "Pamumuno",
        "uk": "Командування",
        "zh-TW": "統率"
      }
    ]
  }
}

Related issues

Part of #815, found in #827.

Checklist

• I have read and followed docs/CODING_RULES.md.
• I have built the project locally (see docs/build/README.md).
  • Windows x64 Release: all 1007 tests pass.
  • In game: a Russian tooltip-snapshot before and after, and the screenshots above in both themes.
• Changes are focused on one concern; the diff is as small as it reasonably can be.

[ezequielzacca]

Thanks. "The damage texts and the Fruits' stat words read right in every language" checks the rendered phrases:

• damageIncrease and damageAbsorb filled with 12, in es, pt, ru, uk, id, tl and zh-TW, against the "After" column above.
• No translation of the two keeps "% of".
• The Command Fruit's {stat} at +0 to +4 in es, pt, ru, uk, zh-TW and id.

The expected strings are written out in the test, so a later data change can't make it pass by changing both sides.